[Bugfix] Dependencies Installation issue #29
Conversation
Signed-off-by: Sahil Suman <[email protected]>
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @sahilsuman933 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @sahilsuman933 on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -62,11 +62,11 @@ | |||
| print("\nInstalling dependencies...") | |||
| def install(packages): | |||
| if packages == "pip install fastapi['all']": | |||
| subprocess.call("pip install fastapi['all']") | |||
| subprocess.call("pip install fastapi['all']", shell=True) | |||
Check notice
Code scanning / Bandit
Starting a process with a partial executable path Note
| @@ -62,11 +62,11 @@ | |||
| print("\nInstalling dependencies...") | |||
| def install(packages): | |||
| if packages == "pip install fastapi['all']": | |||
| subprocess.call("pip install fastapi['all']") | |||
| subprocess.call("pip install fastapi['all']", shell=True) | |||
Check notice
Code scanning / Bandit
subprocess call with shell=True seems safe, but may be changed in the future, consider rewriting without shell Note
| return | ||
| if isinstance(packages, list): | ||
| for package in packages:subprocess.call(package) | ||
| else:subprocess.call(packages) | ||
| for package in packages:subprocess.call(package, shell=True) |
Check failure
Code scanning / Bandit
subprocess call with shell=True identified, security issue. Error
| for package in packages:subprocess.call(package) | ||
| else:subprocess.call(packages) | ||
| for package in packages:subprocess.call(package, shell=True) | ||
| else:subprocess.call(packages, shell=True) |
Check failure
Code scanning / Bandit
subprocess call with shell=True identified, security issue. Error
The dependencies are not getting installed because it is unable to detect the pip properly. To fix that issue I added shell=True which executes the command directly in the shell.
Error Message:
