Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out arrivals / departures with negative ETA #91

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lanami
Copy link
Contributor

@lanami lanami commented Oct 23, 2016

Exclude arrival infos where ETA < 0 from Alexa's announcements (this indicates arrivals and departures which already happened).

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 55.048% when pulling 0dee575 on lanami:84-filter-departed-arrivals into 7e5c265 on OneBusAway:master.

@barbeau
Copy link
Member

barbeau commented Oct 23, 2016

@lanami Thanks for working on this! I'd like to see this as an option that users can turn on and off. For the OBA mobile apps, some users like knowing when they just missed a bus, while others only want upcoming arrivals. Default should be including negative ETAs. Feel free to propose intent and exact keywords.

@barbeau
Copy link
Member

barbeau commented Oct 26, 2016

Closing and re-opening this to trigger the new ICLA bot (hopefully).

@lanami You'll need to sign the ICLA again, which the bot should hopefully link to in it's comment.

@barbeau barbeau closed this Oct 26, 2016
@barbeau barbeau reopened this Oct 26, 2016
@CLAassistant
Copy link

CLAassistant commented Oct 26, 2016

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 55.048% when pulling 0dee575 on lanami:84-filter-departed-arrivals into 7e5c265 on OneBusAway:master.

@lanami
Copy link
Contributor Author

lanami commented Oct 29, 2016

Will do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants