Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a basic CLI #5

Merged
merged 5 commits into from
Nov 16, 2023
Merged

Add a basic CLI #5

merged 5 commits into from
Nov 16, 2023

Conversation

cidrblock
Copy link
Contributor

  • Add a basic CLI, search only
  • Add output in either json or table
  • Include addiitonal formats in the tunein search
  • Update gitiginore to include venv

Thanks for this, it came in handy.

Brad

@JarbasAl JarbasAl requested a review from emphasize November 15, 2023 20:54
@JarbasAl JarbasAl added the enhancement New feature or request label Nov 15, 2023
@JarbasAl
Copy link
Member

thanks for the PR! I like what I see, will try to give it a spin soon

@cidrblock
Copy link
Contributor Author

I realized with the addition of the additional stream types the one picked is not determinisitic. I will have a follow on PR to expose multiple streams, their media type and bit rate. This one was already a little loose in scope.

@emphasize
Copy link
Collaborator

It would need adjustments in setup.py if handled like that

packages=["tunein", "tunein/subcommands"],
# tunein search "Milano Lounge"
Traceback (most recent call last):
  File "/home/ovos/vovos/bin/tunein", line 5, in <module>
    from tunein.cli import main
  File "/home/ovos/vovos/lib/python3.10/site-packages/tunein/cli.py", line 5, in <module>
    from tunein import subcommands
ImportError: cannot import name 'subcommands' from 'tunein' (/home/ovos/vovos/lib/python3.10/site-packages/tunein/__init__.py)

@emphasize
Copy link
Collaborator

Please add - even though the README is a blank slate - a few words about the cli tool

@cidrblock
Copy link
Contributor Author

@emphasize Do you have a minute to approve the workflows to see if the tests pass with the setup changes now?

@JarbasAl JarbasAl merged commit 1f9ff02 into OpenJarbas:dev Nov 16, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants