Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi-universe throughput example #1801

Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

Add multi-universe throughput example #1801

wants to merge 20 commits into from

Conversation

DaAwesomeP
Copy link
Member

This partially (but a big step) solves the issue described in #1793 and at https://groups.google.com/g/open-lighting/c/6yBsDBnpANU. Note that I have only tested this on Debian 11.

Possible milestone #1792

cc @peternewman

peternewman
peternewman reviewed Dec 4, 2022
View reviewed changes
common/io/EPoller.cpp Outdated Show resolved Hide resolved
peternewman
peternewman reviewed Dec 4, 2022
View reviewed changes
common/io/EPoller.cpp Outdated Show resolved Hide resolved
@DaAwesomeP DaAwesomeP changed the base branch from master to 0.10 December 5, 2022 15:42
@DaAwesomeP DaAwesomeP changed the base branch from 0.10 to master December 5, 2022 15:42
@DaAwesomeP DaAwesomeP mentioned this pull request Dec 5, 2022
Merged
@DaAwesomeP DaAwesomeP force-pushed the DaAwesomeP-StreamingClientThroughput branch from 17bb3bf to 845342f Compare December 6, 2022 15:41
@DaAwesomeP DaAwesomeP requested a review from peternewman May 17, 2023 20:19
@DaAwesomeP
Copy link
Member Author

Codespell issue (not related to these changes) was fixed in #1857 on 0.10 branch not yet merged with master.

@DaAwesomeP
Copy link
Member Author

Rebased and passing new tests!

@peternewman peternewman changed the title Remove EPoll delay, add multi-universe throughput example Add multi-universe throughput example Jun 22, 2023
peternewman
peternewman requested changes Jun 22, 2023
View reviewed changes
Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of a minor tidy up

examples/ola-throughput-multi.cpp Outdated Show resolved Hide resolved
@peternewman peternewman added this to the 0.11.0 milestone Jun 22, 2023
@DaAwesomeP
Copy link
Member Author

CI is failing only since the Python 2 action is still in master.

@peternewman
Copy link
Member

CI is failing only since the Python 2 action is still in master.

Do you want to do another master resync to pull in those 0.10 changes?

@DaAwesomeP
Copy link
Member Author

CI is failing only since the Python 2 action is still in master.

Do you want to do another master resync to pull in those 0.10 changes?

On it!

@DaAwesomeP
Copy link
Member Author

DaAwesomeP commented Jun 22, 2023 •
edited
Loading

@peternewman Would you like to get #1861 into the resync?

@DaAwesomeP DaAwesomeP mentioned this pull request Jun 22, 2023
Merged
@DaAwesomeP DaAwesomeP requested a review from peternewman June 22, 2023 12:37
@DaAwesomeP
Copy link
Member Author

@peternewman should be good to go!

@DaAwesomeP
Copy link
Member Author

@peternewman polite ping!

@DaAwesomeP
Copy link
Member Author

@peternewman resynced!

@DaAwesomeP
Copy link
Member Author

Resynced again!

@DaAwesomeP
Copy link
Member Author

@peternewman @kripton rebased again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peternewman peternewman Awaiting requested review from peternewman

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.11.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DaAwesomeP @peternewman