E1.33 cherry pick vii #1960
Merged
E1.33 cherry pick vii #1960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 54d2743)
kripton
approved these changes
Apr 25, 2024
| @@ -30,7 +30,7 @@ using ola::rdm::RDMResponse; | |||
| using ola::rdm::RDMCallback; | |||
|
|
|||
| /** | |||
| * The ManagementEndpoint handles RDMCommands directed at this E1.33 device. It | |||
| * The ManagementEndpoint handles RDMCommands directed at this E1.33 Component. It | |||
There was a problem hiding this comment.
Yeah, I think from the spec that both Controllers and Devices now have management endpoints, I believe Component (or RPT Component) is the overarching term for Controller and/or Device.
There was a problem hiding this comment.
"thing" would also be acceptable! 😜
There was a problem hiding this comment.
I rather meant that the previous "device" was lower-case and the new "Component" is upper-case. No issue with the wording itself
There was a problem hiding this comment.
I think that was device in the generic sense, whereas I was capitalising the official term from the standard to match the standard.
peternewman
merged commit 1593985
into
OpenLightingProject:master
21 of 22 checks passed
|
Merging given @kripton was happy and I ought to try and get the rest merged in... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.