Add fixture fos-technologies/fos-active-winch
#4477
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FloEdelmann
added
new-fixture
Export files validity(Output of test script Test the exported files of selected fixtures against the plugins' export tests. ✔️ fos-technologies / fos-active-winch: d-light / attributes-correctness
✔️ fos-technologies / fos-active-winch: dmxcontrol3 / channel-numbers
✔️ fos-technologies / fos-active-winch: dragonframe / json-schema-conformity
✔️ fos-technologies / fos-active-winch: millumin / json-schema-conformity
✔️ fos-technologies / fos-active-winch: qlcplus_4.12.2 / fixture-tool-validation
✔️ fos-technologies / fos-active-winch: qlcplus_4.12.2 / xsd-schema-conformity
|
kengruven
reviewed
Dec 11, 2024
There was a problem hiding this comment.
This one looks pretty good. I added the 9-ch "ball" mode.
There also seems to be a "bar" option, but even the manual isn't consistent on how many channels that has, so I left it out for now. It should be easy to add as a pixel array with template channels, though.
| }, | ||
| "Reset": { | ||
| "capability": { | ||
| "type": "Generic" |
There was a problem hiding this comment.
Suggested change
| "type": "Generic" | |
| "type": "Generic", | |
| "helpWanted": "At what DMX values does it reset?" |
| }, | ||
| "modes": [ | ||
| { | ||
| "name": "4ch", |
There was a problem hiding this comment.
Suggested change
| "name": "4ch", | |
| "name": "4-channel", |
| "Motor speed", | ||
| "Reset" | ||
| ] | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| }, | |
| { | |
| "name": "9-channel", | |
| "channels": [ | |
| "Motor Position", | |
| "Motor Position fine", | |
| "Motor speed", | |
| "Reset", | |
| "Dimmer", | |
| "Strobe", | |
| "Red", | |
| "Green", | |
| "Blue" | |
| ] | |
| } |
| "capability": { | ||
| "type": "Intensity" | ||
| } | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| }, | |
| "Strobe": { | |
| "type": "Generic", | |
| "helpWanted": "What strobe effects at what values?" | |
| }, | |
| "Red": { | |
| "type": "ColorIntensity", | |
| "color": "Red" | |
| }, | |
| "Green": { | |
| "type": "ColorIntensity", | |
| "color": "Green" | |
| }, | |
| "Blue": { | |
| "type": "ColorIntensity", | |
| "color": "Blue" | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fos-technologies/fos-active-winchFixture warnings / errors
Thank you Anonymous!