-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patch 1 - Adding LightFactory and Strand NEO to controller list. #255
Conversation
Adding manufacturer 0x736c (Stand Lihgting) and the NEO console.
Added manufacturer Dream Solutions (0x2239), product LightFactory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just an option for some improvement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor spacing issue left.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes should make flake8 happy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks very much @msearancke . We still need to finish our deployment process so these things appear automagically on the website, but there's a PR in progress for that so it's now appeared on my staging site and will get deployed to the live one in due course (either manually or when that PR gets merged): We need to rework image grabbing too #132 . |
No description provided.