Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch 1 - Adding LightFactory and Strand NEO to controller list. #255

Merged
merged 7 commits into from
Mar 18, 2019

Conversation

msearancke
Copy link
Contributor

No description provided.

Adding manufacturer 0x736c (Stand Lihgting) and the NEO console.
Added manufacturer Dream Solutions (0x2239), product LightFactory
Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just an option for some improvement.

data/controller_data.py Show resolved Hide resolved
data/controller_data.py Show resolved Hide resolved
Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a minor spacing issue left.

data/controller_data.py Outdated Show resolved Hide resolved
data/controller_data.py Outdated Show resolved Hide resolved
Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should make flake8 happy.

data/controller_data.py Outdated Show resolved Hide resolved
data/controller_data.py Outdated Show resolved Hide resolved
Copy link
Member

@peternewman peternewman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@peternewman peternewman merged commit c0e8373 into OpenLightingProject:master Mar 18, 2019
@msearancke msearancke deleted the patch-1 branch March 18, 2019 02:23
@peternewman
Copy link
Member

Thanks very much @msearancke . We still need to finish our deployment process so these things appear automagically on the website, but there's a PR in progress for that so it's now appeared on my staging site and will get deployed to the live one in due course (either manually or when that PR gets merged):
https://peter-ola-rdm-app.appspot.com/controller/browse?manufacturer=29548
https://peter-ola-rdm-app.appspot.com/controller/browse?manufacturer=8761

We need to rework image grabbing too #132 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants