Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename header to skip authorization #9789

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Nov 20, 2024

Core is not the only service that should bypass the authorization

osrd-chart PR: OpenRailAssociation/osrd-chart#39

@flomonster flomonster requested review from a team as code owners November 20, 2024 09:46
@flomonster flomonster requested a review from eckter November 20, 2024 09:46
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realize, isn't this some kind of backdoor in editoast (nothing change since the apparition of the core header, I realize this PR doesn't make it worse than it already was). What the risk?

@flomonster
Copy link
Contributor Author

I realize, isn't this some kind of backdoor in editoast (nothing change since the apparition of the core header, I realize this PR doesn't make it worse than it already was). What the risk?

It's a kind of backdoor but it cannot be exploit since the gateway reject requests with this header and editoast can't be queried from outside it's network.

Another way to do it is to use a token that have the necessary permissions and query the gateway instead.

@flomonster flomonster added this pull request to the merge queue Nov 21, 2024
Merged via the queue into dev with commit dd9941f Nov 21, 2024
27 checks passed
@flomonster flomonster deleted the fam/rename-header-skip-authz branch November 21, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants