Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump nokogiri and qa #80

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link

@dependabot dependabot bot commented on behalf of github Aug 31, 2021

Bumps nokogiri and qa. These dependencies needed to be updated together.
Updates nokogiri from 1.6.8.1 to 1.12.4

Release notes

Sourced from nokogiri's releases.

1.12.4 / 2021-08-29

Notable fix: Namespace inheritance

Namespace behavior when reparenting nodes has historically been poorly specified and the behavior diverged between CRuby and JRuby. As a result, making this behavior consistent in v1.12.0 introduced a breaking change.

This patch release reverts the Builder behavior present in v1.12.0..v1.12.3 but keeps the Document behavior. This release also introduces a Document attribute to allow affected users to easily change this behavior for their legacy code without invasive changes.

Compensating Feature in XML::Document

This release of Nokogiri introduces a new Document boolean attribute, namespace_inheritance, which controls whether children should inherit a namespace when they are reparented. Nokogiri::XML:Document defaults this attribute to false meaning "do not inherit," thereby making explicit the behavior change introduced in v1.12.0.

CRuby users who desire the pre-v1.12.0 behavior may set document.namespace_inheritance = true before reparenting nodes.

See https://nokogiri.org/rdoc/Nokogiri/XML/Document.html#namespace_inheritance-instance_method for example usage.

Fix for XML::Builder

However, recognizing that we want Builder-created children to inherit namespaces, Builder now will set namespace_inheritance=true on the underlying document for both JRuby and CRuby. This means that, on CRuby, the pre-v1.12.0 behavior is restored.

Users who want to turn this behavior off may pass a keyword argument to the Builder constructor like so:

Nokogiri::XML::Builder.new(namespace_inheritance: false)

See https://nokogiri.org/rdoc/Nokogiri/XML/Builder.html#label-Namespace+inheritance for example usage.

Downstream gem maintainers

Note that any downstream gems may want to specifically omit Nokogiri v1.12.0--v1.12.3 from their dependency specification if they rely on child namespace inheritance:

Gem::Specification.new do |gem|
  # ...
  gem.add_runtime_dependency 'nokogiri', '!=1.12.3', '!=1.12.2', '!=1.12.1', '!=1.12.0'
  # ...
end

Fixed

  • [JRuby] Fix NPE in Schema parsing when an imported resource doesn't have a systemId. [#2296] (Thanks, @​pepijnve!)

... (truncated)

Changelog

Sourced from nokogiri's changelog.

1.12.4 / unreleased

Notable fix: Namespace inheritance

Namespace behavior when reparenting nodes has historically been poorly specified and the behavior diverged between CRuby and JRuby. As a result, making this behavior consistent in v1.12.0 introduced a breaking change.

This patch release reverts the Builder behavior present in v1.12.0..v1.12.3 but keeps the Document behavior. This release also introduces a Document attribute to allow affected users to easily change this behavior for their legacy code without invasive changes.

Compensating Feature in XML::Document

This release of Nokogiri introduces a new Document boolean attribute, namespace_inheritance, which controls whether children should inherit a namespace when they are reparented. Nokogiri::XML:Document defaults this attribute to false meaning "do not inherit," thereby making explicit the behavior change introduced in v1.12.0.

CRuby users who desire the pre-v1.12.0 behavior may set document.namespace_inheritance = true before reparenting nodes.

See https://nokogiri.org/rdoc/Nokogiri/XML/Document.html#namespace_inheritance-instance_method for example usage.

Fix for XML::Builder

However, recognizing that we want Builder-created children to inherit namespaces, Builder now will set namespace_inheritance=true on the underlying document for both JRuby and CRuby. This means that, on CRuby, the pre-v1.12.0 behavior is restored.

Users who want to turn this behavior off may pass a keyword argument to the Builder constructor like so:

Nokogiri::XML::Builder.new(namespace_inheritance: false)

See https://nokogiri.org/rdoc/Nokogiri/XML/Builder.html#label-Namespace+inheritance for example usage.

Downstream gem maintainers

Note that any downstream gems may want to specifically omit Nokogiri v1.12.0--v1.12.3 from their dependency specification if they rely on child namespace inheritance:

Gem::Specification.new do |gem|
  # ...
</tr></table> 

... (truncated)

Commits

Updates qa from 0.3.0 to 5.6.0

Release notes

Sourced from qa's releases.

v5.6.0

The only update in this release is the support of Rails 6.1. This did not require code changes.

NOTE: One of the commits states that it allows for Rails 6.2 and is recorded automatically in the CHANGELOG. This is incorrect. It allows for use with Rails 6.1

v5.5.2

Full Changelog

Closed issues:

  • OCLC_FAST linked data connection times out #327
  • generated sample URL has extra parameters #326

Merged pull requests:

  • do not overwrite passed in replacements hash #329 (elrayle)
  • encode query for linked data access to OCLC FAST #328 (elrayle)

v5.5.1

Adjust URLs for Library of Congress

Although the main API URLs switched to https, the URLs passed as parameters to identify subauthority, vocabulary, etc. continue to use http. This release reinstates these URLs back to http while keeping the API URLs using https.

v5.5.0

Fix Broken Access to Library of Congress

This release addresses a change in the Library of Congress API URL to use https instead of http. Update to this release to restore access to Library of Congress.

v5.4.0

Features

  • Adding config option for Geonames URLs #312 (jeremyf)

Other

  • Align style practice with current Samvera norms #315 (bess)
  • Updating Rails development dependency #313 (jeremyf)
  • Remove Ruby 2.4 / Rails 6.0 build #311 (bkeese)
  • Adding Ruby 2.7.z and Rails 6.y.z releases to the CircleCI build configuration #310 (jrgriffiniii)
  • Update Geonames URIs to https #307 (no-reply)

v5.3.1

IP Logging failures seen in v5.3.0

IP Logging is off by default and requires setting Qa.config.suppress_ip_data_from_log=false in config/initializers/qa.rb in your app. If you have not done that, then this bug fix is not required.

If you are using IP logging (i.e. Qa.config.suppress_ip_data_from_log==false), then you will want to update to this release. In v5.3.0, the IP logging causes failures if the location cannot be retrieved from the http request.

... (truncated)

Changelog

Sourced from qa's changelog.

5.6.0 (2021-01-11)

Full Changelog

Closed issues:

  • support Rails 6.1? #330

Merged pull requests:

v5.5.2 (2020-12-02)

Full Changelog

Closed issues:

  • OCLC_FAST linked data connection times out #327
  • generated sample URL has extra parameters #326

Merged pull requests:

  • do not overwrite passed in replacements hash #329 (elrayle)
  • encode query for linked data access to OCLC FAST #328 (elrayle)

v3.1.0 (2020-08-14)

Full Changelog

v4.3.0 (2020-08-14)

Full Changelog

v2.3.0 (2020-08-14)

Full Changelog

Merged pull requests:

v5.5.1 (2020-08-14)

Full Changelog

Closed issues:

  • Library of Congress now redirecting HTTP requests to HTTPS #320

... (truncated)

Commits
  • 489dcbd prep for release 5.6.0
  • 6ef7587 Merge pull request #332 from jrochkind/rails_6_1
  • 22fbfc5 add rails 6.1 build to circleci
  • 13a30a7 allow rails 6.2
  • d23a5ae prep release 5.5.2
  • a5bef02 Merge pull request #328 from samvera/fix/327_oclcfast_timeout
  • 61d0f6d Merge pull request #329 from samvera/fix/326_replacements
  • d366c76 do not overwrite passed in replacements hash
  • 790499d encode query for linked data access to OCLC FAST
  • 868237c Merge pull request #324 from samvera/release/5.5.1
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) and [qa](https://github.com/projecthydra/questioning_authority). These dependencies needed to be updated together.

Updates `nokogiri` from 1.6.8.1 to 1.12.4
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.6.8.1...v1.12.4)

Updates `qa` from 0.3.0 to 5.6.0
- [Release notes](https://github.com/projecthydra/questioning_authority/releases)
- [Changelog](https://github.com/samvera/questioning_authority/blob/main/CHANGELOG.md)
- [Commits](samvera/questioning_authority@v0.3.0...v5.6.0)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: direct:production
- dependency-name: qa
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Aug 31, 2021
@dependabot dependabot bot mentioned this pull request Aug 31, 2021
@dependabot @github
Copy link
Author

dependabot bot commented on behalf of github Oct 19, 2022

Superseded by #87.

@dependabot dependabot bot closed this Oct 19, 2022
@dependabot dependabot bot deleted the dependabot/bundler/nokogiri-and-qa-1.12.4 branch October 19, 2022 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants