Adds cancellation token support for long running work grains. #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a breaking change to the package, as now implementations of grains need to have the additional parameter of
GrainCancellationToken
added.Previous signature that needed implementing:
New signature:
You will be safe to just add this parameter to all of your long running grain implementations, but now you have the option of performing cancellation logic (added a few tests to demonstrate this)
CancellationTokens
now provided to sync work grain execution through aStart
overload.Start
method is still available, and just news up a cancellation token for backwards compatibility.Fixes #50
Type of Change
Use an
x
in between the[ ]
for each line applicable to the type of change for this PRDescribe testing that was performed for your change
New unit tests against cancellation token support
Checklist
dotnet-format
locally