Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use catalog from prod and fix output url format change from Finch 0.8.0 #244

Merged
merged 2 commits into from
Jan 14, 2022

Conversation

tlvu
Copy link
Contributor

@tlvu tlvu commented Jan 14, 2022

climex.ipynb and forecasts.ipynb use the catalog that are not deployed on test servers. We need to force the catalog from the production server for these notebooks to pass on test servers.

Finch 0.8.0 from PR bird-house/birdhouse-deploy#231 seems to have changed the output url format, causing the following Jenkins error in subset-user-input.ipynb:

  ___ pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb::Cell 15 ___
  Notebook cell execution failed
  Cell 15: Cell outputs differ

  Input:
  # wait for process to complete before running this cell (the process is async)
  tasmin_subset = result_tasmin.get().output
  tasmin_subset

  Traceback:
   mismatch 'text/plain'

   assert reference_output == test_output failed:

    "'https://WPS..._v2_sub.ncml'" == "'https://WPS...8fa_sub.ncml'"
    Skipping 40 identical leading characters in diff, use -v to show
    - /nrcan_v2_x9fja8fa_sub.ncml'
    ?           ---------
    + /nrcan_v2_sub.ncml'

  ___ pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb::Cell 17 ___
  Notebook cell execution failed
  Cell 17: Cell outputs differ

  Input:
  # wait for process to complete before running this cell (the process is async)
  tasmax_subset = result_tasmax.get().output
  tasmax_subset

  Traceback:
   mismatch 'text/plain'

   assert reference_output == test_output failed:

    "'https://WPS..._v2_sub.ncml'" == "'https://WPS...a44_sub.ncml'"
    Skipping 40 identical leading characters in diff, use -v to show
    - /nrcan_v2_qbj57a44_sub.ncml'
    ?           ---------
    + /nrcan_v2_sub.ncml'

tlvu added 2 commits January 14, 2022 11:18
….8.0

```
  ___ pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb::Cell 15 ___
  Notebook cell execution failed
  Cell 15: Cell outputs differ

  Input:
  # wait for process to complete before running this cell (the process is async)
  tasmin_subset = result_tasmin.get().output
  tasmin_subset

  Traceback:
   mismatch 'text/plain'

   assert reference_output == test_output failed:

    "'https://WPS..._v2_sub.ncml'" == "'https://WPS...8fa_sub.ncml'"
    Skipping 40 identical leading characters in diff, use -v to show
    - /nrcan_v2_x9fja8fa_sub.ncml'
    ?           ---------
    + /nrcan_v2_sub.ncml'

  ___ pavics-sdi-master/docs/source/notebooks/subset-user-input.ipynb::Cell 17 ___
  Notebook cell execution failed
  Cell 17: Cell outputs differ

  Input:
  # wait for process to complete before running this cell (the process is async)
  tasmax_subset = result_tasmax.get().output
  tasmax_subset

  Traceback:
   mismatch 'text/plain'

   assert reference_output == test_output failed:

    "'https://WPS..._v2_sub.ncml'" == "'https://WPS...a44_sub.ncml'"
    Skipping 40 identical leading characters in diff, use -v to show
    - /nrcan_v2_qbj57a44_sub.ncml'
    ?           ---------
    + /nrcan_v2_sub.ncml'
```
@tlvu tlvu requested a review from huard January 14, 2022 16:59
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@huard huard merged commit a27006b into master Jan 14, 2022
@huard huard deleted the use-catalog-from-prod branch January 14, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants