-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust HAProxy's existance to log for console masters. #11433
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, LGTM, however should be merged into the Add support for Proxy Protocol
patch itself instead of a new patch.
Additionally, if you are moving things around anyway, this might be nicer to be right under the other logging in bind(), e.g. under the velocity native logs, just to keep everything neatly in one place.
So I'm still new with patching and the way paper does it's changes, however. I assume I would have to edit the |
Yea exactly, you'd edit that patch as per CONTRIB instructions. If you have any more questions, feel 100% to just ask in paper-dev on discord, I am sure someone is gonna be around to help you with it. Worst case I can also just quickly merge this for you if everything goes wrong 👍 |
9111582
to
057c0e2
Compare
@lynxplay so out of my own curiosity, what has been chanced in support of the PR? Some other files/patches where modified as well. |
The diff was moved to a different patch, a patch that added the support in the first place. |
This is a VERY minor change, so minimal but VERY useful for system administrators. (I am one, and this was so confusing).
Exact same PR concept as: PaperMC/Velocity#1436