feat: Add server registered/unregistered events #1386
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the new API should be annotated with |
kennytv
approved these changes
Jul 22, 2024
4drian3d
approved these changes
Jul 24, 2024
4drian3d
requested changes
Jul 24, 2024
api/src/main/java/com/velocitypowered/api/event/proxy/server/ServerUnregisteredEvent.java
Show resolved
Hide resolved
api/src/main/java/com/velocitypowered/api/event/proxy/server/ServerRegisteredEvent.java
Show resolved
Hide resolved
4drian3d
approved these changes
Jul 24, 2024
powercasgamer
suggested changes
Jul 24, 2024
api/src/main/java/com/velocitypowered/api/event/proxy/server/ServerRegisteredEvent.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/velocitypowered/api/event/proxy/server/ServerUnregisteredEvent.java
Outdated
Show resolved
Hide resolved
Co-authored-by: powercas_gamer <[email protected]>
powercasgamer
suggested changes
Jul 24, 2024
api/src/main/java/com/velocitypowered/api/event/proxy/server/ServerRegisteredEvent.java
Outdated
Show resolved
Hide resolved
api/src/main/java/com/velocitypowered/api/event/proxy/server/ServerUnregisteredEvent.java
Outdated
Show resolved
Hide resolved
Co-authored-by: powercas_gamer <[email protected]>
powercasgamer
approved these changes
Jul 24, 2024
pull bot
pushed a commit
to WiIIiam278/Velocity
that referenced
this pull request
Jul 25, 2024
* feat: Add server registered/unregistered events * Annotate new API with `@Beta` * Migrate from classes to records * Add null checks * Fix code style indent * Add links in documentation * Fix docs indent --------- Co-authored-by: powercas_gamer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These events are useful for handling dynamically registered servers by other plugins or reloads of velocity configuration.
This PR replaces #1050, due to owners inactivity.