Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump adventure to 4.18.0 #1481

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

RealBauHD
Copy link
Contributor

No description provided.

@electronicboy
Copy link
Member

electronicboy commented Dec 23, 2024 via email

@RealBauHD
Copy link
Contributor Author

I went through the changes from adventure and didn't notice anything that needed attention.
Or have I overlooked something in the VirtualComponents?
4.16.0 and 4.17.0 were also just simple bumps.

@electronicboy
Copy link
Member

electronicboy commented Dec 23, 2024 via email

@RealBauHD
Copy link
Contributor Author

Oh you're right, I look into that

@RealBauHD RealBauHD marked this pull request as draft December 23, 2024 02:04
@RealBauHD
Copy link
Contributor Author

RealBauHD commented Dec 23, 2024

2024-12-23_03 44 40
It already works
because the serializer translates the gson types and not the components

@electronicboy electronicboy marked this pull request as ready for review December 23, 2024 02:58
Copy link
Member

@electronicboy electronicboy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd forgotten that we'd gone that route in the interim

@electronicboy electronicboy merged commit 1db8c8c into PaperMC:dev/3.0.0 Dec 23, 2024
1 check passed
pull bot pushed a commit to WiIIiam278/Velocity that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants