Show proxy-wide online players in server ping #811
+41
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
electronicboy
requested changes
Aug 3, 2022
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
|
Just realized that I was building on Java 18, and |
|
Just now tested it with 14 clients, the preview should be working properly. I updated the PR description with screenshots of it. |
hugmanrique
suggested changes
Aug 3, 2022
proxy/src/main/java/com/velocitypowered/proxy/config/VelocityConfiguration.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
proxy/src/main/java/com/velocitypowered/proxy/connection/util/ServerListPingHandler.java
Outdated
Show resolved
Hide resolved
BBaoVanC
force-pushed
the
ping-sample-players
branch
from
bdaad74 to
1505687
Compare
hugmanrique
reviewed
Aug 6, 2022
api/src/main/java/com/velocitypowered/api/proxy/server/ServerPing.java
Outdated
Show resolved
Hide resolved
hugmanrique
approved these changes
Aug 7, 2022
BBaoVanC
force-pushed
the
ping-sample-players
branch
from
8ba31f1 to
6d62a4c
Compare
BBaoVanC
force-pushed
the
ping-sample-players
branch
from
6d62a4c to
c6773fb
Compare
|
Rebased it, @electronicboy could you look at/review this? |
4drian3d
approved these changes
Feb 5, 2023
BBaoVanC
force-pushed
the
ping-sample-players
branch
from
907c3c6 to
e01ff21
Compare
BBaoVanC
force-pushed
the
ping-sample-players
branch
from
e01ff21 to
c8d3280
Compare
BBaoVanC
force-pushed
the
ping-sample-players
branch
from
c8d3280 to
a6e1bf4
Compare
BBaoVanC
force-pushed
the
ping-sample-players
branch
from
a6e1bf4 to
7c2b412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it so you can see online players on the entire proxy when hovering over the player count (only has an effect when ping passthrough is disabled, otherwise the backend server's player list is already used).
Preview is limited to 12 players, same as vanilla:
Players that have "Allow Server Listings" set to false show up as "Anonymous Player" (same as vanilla):
And when refreshing the server list, the list reshuffles.