-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add push messaging (+ other assorted improvements) #124
Draft
Rumperuu
wants to merge
428
commits into
development
Choose a base branch
from
ben/feature/push-notifications
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chart needs fixing and currencies should pipe to show currency
Adding new graph views and fixes
Amended close button
0.1.8 Release
added yearly submit
This was
linked to
issues
Dec 10, 2020
Rumperuu
changed the title
Push Notifications
Add push messaging (+ other assorted improvements)
Mar 20, 2021
This was
linked to
issues
Mar 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB the Travis tests fail because it can't start the messaging service, but I think that will need someone with more Travis/Angular experience than me to fix.
This PR was originally intended to only add push notification functionality to the Web client. However, it has since expanded to into a bit of a monolith, which certainly isn't ideal and should be avoided in future, but I think I'm the only person working on this at the moment so it shouldn't cause any major issues.
This PR adds the following:
See also Pear-Trading/LocalSpend-Tracker#12 & Pear-Trading/Foodloop-Server#140
Closes #123 #125 #127 #132 #133 #140 #141