Merge pull request #506 from Pennyw0rth/ruff

fix ruff

nxc/modules/enum_impersonate.py

@@ -1,7 +1,8 @@
-#Author: 
-# deathflamingo
 class NXCModule:
-    """Enumerate SQL Server users with impersonation rights"""
+    """
+    Enumerate SQL Server users with impersonation rights
+    Module by deathflamingo
+    """
 
     name = "enum_impersonate"
     description = "Enumerate users with impersonation privileges"
@@ -28,7 +29,7 @@ def get_impersonate_users(self) -> list:
         """
         Fetches a list of users with impersonation rights.
 
-        Returns:
+        Returns
         -------
         list: List of user names.
         """

nxc/modules/enum_links.py

@@ -1,7 +1,8 @@
-#Author: 
-# deathflamingo
 class NXCModule:
-    """Enumerate SQL Server linked servers"""
+    """
+    Enumerate SQL Server linked servers
+    Module by deathflamingo
+    """
 
     name = "enum_links"
     description = "Enumerate linked SQL Servers"
@@ -28,7 +29,7 @@ def get_linked_servers(self) -> list:
         """
         Fetches a list of linked servers.
 
-        Returns:
+        Returns
         -------
         list: List of linked server names.
         """

nxc/modules/enum_logins.py

@@ -1,7 +1,8 @@
-#Author: 
-# deathflamingo
 class NXCModule:
-    """Enumerate SQL Server logins"""
+    """
+    Enumerate SQL Server logins
+    Module by deathflamingo
+    """
 
     name = "enum_logins"
     description = "Enumerate SQL Server logins"
@@ -28,7 +29,7 @@ def get_logins(self) -> list:
         """
         Fetches a list of SQL Server logins.
 
-        Returns:
+        Returns
         -------
         list: List of login names.
         """

nxc/modules/exec_on_link.py

@@ -1,7 +1,8 @@
-#Author: 
-# deathflamingo
 class NXCModule:
-    """Execute commands on linked servers"""
+    """
+    Execute commands on linked servers
+    Module by deathflamingo
+    """
 
     name = "exec_on_link"
     description = "Execute commands on a SQL Server linked server"
@@ -35,9 +36,7 @@ def on_login(self, context, connection):
         self.execute_on_link()
 
     def execute_on_link(self):
-        """
-        Executes the specified command on the linked server.
-        """
+        """Executes the specified command on the linked server."""
         query = f"EXEC ('{self.command}') AT [{self.linked_server}];"
         result = self.mssql_conn.sql_query(query)
         self.context.log.display(f"Command output: {result}")

nxc/modules/link_enable_xp.py

@@ -1,7 +1,8 @@
-#Author: 
-# deathflamingo
 class NXCModule:
-    """Enable or disable xp_cmdshell on a linked SQL server"""
+    """
+    Enable or disable xp_cmdshell on a linked SQL server
+    Module by deathflamingo
+    """
 
     name = "link_enable_xp"
     description = "Enable or disable xp_cmdshell on a linked SQL server"
@@ -43,10 +44,10 @@ def enable_xp_cmdshell(self):
         """Enable xp_cmdshell on the linked server."""
         query = f"EXEC ('sp_configure ''show advanced options'', 1; RECONFIGURE;') AT [{self.linked_server}]"
         self.context.log.display(f"Enabling advanced options on {self.linked_server}...")
-        out=self.query_and_get_output(query)
+        out = self.query_and_get_output(query)
         query = f"EXEC ('sp_configure ''xp_cmdshell'', 1; RECONFIGURE;') AT [{self.linked_server}]"
         self.context.log.display(f"Enabling xp_cmdshell on {self.linked_server}...")
-        out=self.query_and_get_output(query)
+        out = self.query_and_get_output(query)
         self.context.log.display(out)
         self.context.log.success(f"xp_cmdshell enabled on {self.linked_server}")
 

nxc/modules/link_xpcmd.py

@@ -1,7 +1,8 @@
-#Author: 
-# deathflamingo
 class NXCModule:
-    """Run xp_cmdshell commands on a linked SQL server"""
+    """
+    Run xp_cmdshell commands on a linked SQL server
+    Module by deathflamingo
+    """
 
     name = "link_xpcmd"
     description = "Run xp_cmdshell commands on a linked SQL server"

nxc/modules/notepad++.py

@@ -20,7 +20,7 @@ def options(self, context, module_options):
 
     def on_admin_login(self, context, connection):
         found = 0
-        for directory in connection.conn.listPath("C$",  "Users\\*"):
+        for directory in connection.conn.listPath("C$", "Users\\*"):
             if directory.get_longname() not in self.false_positive and directory.is_directory():
                 try:
                     notepad_backup_dir = f"Users\\{directory.get_longname()}\\AppData\\Roaming\\Notepad++\\backup\\"

nxc/modules/powershell_history.py

@@ -25,7 +25,7 @@ def options(self, _, module_options):
         self.export = bool(module_options.get("EXPORT", False))
 
     def on_admin_login(self, context, connection):
-        for directory in connection.conn.listPath("C$",  "Users\\*"):
+        for directory in connection.conn.listPath("C$", "Users\\*"):
             if directory.get_longname() not in self.false_positive and directory.is_directory():
                 try:
                     powershell_history_dir = f"Users\\{directory.get_longname()}\\AppData\\Roaming\\Microsoft\\Windows\\PowerShell\\PSReadLine\\"
@@ -37,12 +37,8 @@ def on_admin_login(self, context, connection):
                             connection.conn.getFile("C$", file_path, buf.write)
                             buf.seek(0)
                             file_content = buf.read().decode("utf-8", errors="ignore").lower()                
-                            keywords = []
-                            for keyword in self.sensitive_keywords:
-                                if keyword in file_content:
-                                    keywords.append(keyword.upper())
-
-                            if keyword:
+                            keywords = [keyword.upper() for keyword in self.sensitive_keywords if keyword in file_content]
+                            if len(keywords):
                                 context.log.highlight(f"C:\\{file_path} [ {' '.join(keywords)} ]")
                             else:
                                 context.log.highlight(f"C:\\{file_path}")

nxc/modules/shadowrdp.py

@@ -38,7 +38,7 @@ def on_admin_login(self, context, connection):
                     remoteOps._RemoteOperations__rrp,
                     regHandle, 
                     "Software\\Policies\\Microsoft\\Windows NT\\Terminal Services\\"
-                )['phkResult']
+                )["phkResult"]
 
                 # Checks if the key already exists or not
                 try: