make shmread/shmwrite work with args beyond I32/2GB #22897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PERL_ARGS_ASSERT_DO_SHMIO is equivalent to `assert(mark); assert(sp)`. There is no point in checking pointers that have already been dereferenced by previous statements. An optimizing compiler will simply remove those asserts as no-ops. Move the asserts up to before any of the function arguments are used.
- Extend mpos/msize to the full size_t/STRLEN range (whatever that is on the current platform). - Fully validate the range of all incoming values, including making sure that mpos+misze does not overflow (I think you used to be able to crash perl with this before). - Assert that the optype is either OP_SHMREAD or OP_SHMWRITE (because the code blindly performs a shmwrite() if optype is not OP_SHMREAD). - Switch to Perl_croak_nocontext because why not. Fixes Perl#22895.
Leont
approved these changes
Jan 8, 2025
Guard tests behind PERL_TEST_MEMORY because we're allocating a 2GB
shared mem segment and a 2GB scalar buffer. These tests used to fail (or
crash) before the do_shmio() I32 fixes.
Also fix the error message if the initial shmget fails
("IPC::SharedMem->new" was a copy/paste oversight from when these tests
were copied in from IPC::SysV in 2d5385e).
Also test that shmwrite() from a tied buffer only calls FETCH once while
we're at it.
|
I missed a piece of debugging code in the test ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend mpos/msize to the full size_t/STRLEN range (whatever that is on the current platform).
Tests included.
Fixes #22895.