Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add player and inventory saving #878

Merged
merged 13 commits into from
Jan 2, 2025

Conversation

OneAvargeCoder193
Copy link
Contributor

@OneAvargeCoder193 OneAvargeCoder193 commented Jan 1, 2025

This makes the player's position and inventory save at a 5 second interval.

@OneAvargeCoder193 OneAvargeCoder193 marked this pull request as ready for review January 1, 2025 21:45
Copy link
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to work! I can't wait to merge this, this will be so helpful in further testing.
But there are a few small things that I'd like you to fix first.

src/Inventory.zig Outdated Show resolved Hide resolved
src/Inventory.zig Outdated Show resolved Hide resolved
src/Inventory.zig Outdated Show resolved Hide resolved
src/Inventory.zig Outdated Show resolved Hide resolved
src/server/server.zig Outdated Show resolved Hide resolved
src/server/world.zig Outdated Show resolved Hide resolved
src/server/world.zig Outdated Show resolved Hide resolved
src/server/world.zig Outdated Show resolved Hide resolved
src/server/world.zig Outdated Show resolved Hide resolved
src/server/world.zig Outdated Show resolved Hide resolved
Copy link
Member

@IntegratedQuantum IntegratedQuantum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were still some small problems left, like you forgot to change replace buffer in one place, but I decided to just fix them myself so we can merge this faster.

@IntegratedQuantum IntegratedQuantum merged commit 5986c76 into PixelGuys:master Jan 2, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants