Merge pull request #2 from PlumTreeSystems/1-fix

thrown OK response everytime notifyAction gets a response from paysera
PlumTreeSystems · May 12, 2020 · ee82fc5 · ee82fc5
2 parents 579b040 + 41c51ab
commit ee82fc5
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/Action/NotifyAction.php b/Action/NotifyAction.php
@@ -40,19 +40,22 @@ public function execute($request)
 
         $response = $this->api->doNotify($httpRequest->query);
 
+        if (!$response) {
+            throw new \WebToPayException('Wrong parameters');
+        }
+
         switch ($response['status']) {
             case '0':
                 $model['status'] = 'FAILED';
                 break;
             case '1':
                 $model['status'] = 'COMPLETED';
-                throw new HttpResponse('OK');
                 break;
             case '2':
                 $model['status'] = 'NOT_EXECUTED';
                 break;
         }
-
+        throw new HttpResponse('OK');
     }
 
     /**

diff --git a/Tests/Action/NotifyActionTest.php b/Tests/Action/NotifyActionTest.php
@@ -29,6 +29,7 @@ public function shouldBeSubClassOfGatewayAwareAction()
      */
     public function shouldThrowExceptionWithWrongParams()
     {
+        $this->expectException(\WebToPayException::class);
         $expectedModel = array('foo' => 'fooVal');
 
         $apiMock = $this->createMock(Api::class);