Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display pooled 3-year CPS as dataset for state-level runs #2231

Merged
merged 4 commits into from
Dec 16, 2024

Conversation

anth-volk
Copy link
Collaborator

Description

Fixes #2230.

Changes

If opening the Reproduce in Python page for a state-level simulation run, the Reproduce code now properly selects the pooled 3-year CPS as dataset.

Screenshots

Screen Shot 2024-11-29 at 6 31 10 PM

Tests

Tests have been updated and a test has been added to ensure the Reproduce code is generated correctly.

@anth-volk anth-volk force-pushed the fix/2230-pooled-reproduce branch from 599aaea to 59dd51e Compare December 5, 2024 21:27
@anth-volk
Copy link
Collaborator Author

Note: Do not yet merge; dealing with merge conflicts has introduced bug

@MaxGhenis MaxGhenis marked this pull request as draft December 5, 2024 22:11
@anth-volk anth-volk requested a review from MaxGhenis December 6, 2024 14:17
@anth-volk anth-volk marked this pull request as ready for review December 6, 2024 14:17
@anth-volk
Copy link
Collaborator Author

Re-requesting review due to size of changes needed to deal with merge conflicts

@MaxGhenis MaxGhenis merged commit 114b62f into PolicyEngine:master Dec 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Modify state-level runs to properly select pooled 3-year CPS as dataset
2 participants