perf: remove person join from actors modal #26623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @aspicer! 👋 |
|
Size Change: 0 B Total Size: 1.11 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
aspicer
force-pushed
the
move-person-modal-filters-down
branch
from
07929e6 to
1320bac
Compare
…osthog into move-person-modal-filters-down
…osthog into move-person-modal-filters-down
| ast.Constant(value=1), | ||
| ], | ||
| select_from=ast.JoinExpr(table=ast.Field(chain=["persons"])), | ||
| where=None, | ||
| order_by=[ast.OrderExpr(expr=ast.Field(chain=["created_at"]), order="DESC")], | ||
| order_by=[ast.OrderExpr(expr=ast.Field(chain=["id"]), order="ASC")], |
There was a problem hiding this comment.
do we need to have an order_by clause for just ids?
Guessing we add it by default here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Person modals are failing for some teams with a lot of people for OOM
I was able to fix this by changing the join mode, but this made it slow.
Changes
If we do not request any fields that require joining against persons or groups, don't do it. Just return ids. The actors modals just take the IDs and hydrate the people, so this join is superfluous.
Remove the "created at" field from the actor modal.
Does this work well for both Cloud and self-hosted?
Yes
How did you test this code?
Tested locally. Made unit tests pass.