fix: Update Svelte Onboarding Code #27155
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rafaeelaudibert
requested changes
Dec 26, 2024
There was a problem hiding this comment.
Hey, @nermalcat69! This is great! I agree this is a much better fix - and ChatGPT agrees with the both of us, I'm not the best at Svelte :)
There are two changes we might want here:
- Can you make sure you're importing
onMount? My understanding is that it's not available by default, correct me if I'm wrong - Can you by any chance update our Svelte documentation on the website as well? It's fine if you can't get to it, I can always try and update it myself, but I believe you have more knowledge than I have :)
The docs are live here: https://posthog.com/docs/libraries/svelte
Our docs live in here, and it should be easy to find where to update it: https://github.com/PostHog/posthog.com
|
Sureee, Thanks @rafaeelaudibert i'll get back to you ASAP! |
Make sure you're enjoying the end-of-year break as well :). Thank you! |
|
Review it whenever you get time and thanks for your time 💯 Merry Belated Christmas 😄 |
|
The docs pr: PostHog/posthog.com#10223 |
11 tasks
rafaeelaudibert
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I was setting up posthog for my website saasplates.com which is written in svelte and i noticed this problem so thought i should fix it.
Changes
Added OnMount as it's the best one and works best when a user visits the site.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?