fix(GODT-3036): Keep contentID order for attachment in FakeServer. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other than the minor comment, could you add a commit description about why this is import/necessary? |
rlejeune74
force-pushed
the
feat/godt-3036
branch
from
a978881 to
f4421b7
Compare
rlejeune74
force-pushed
the
feat/godt-3036
branch
from
f4421b7 to
d515be7
Compare
LBeernaertProton
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline attachment order is preserved using the attachment contentID.
Message attachment IDs list should then be computed with contentID properly sorted to ensure inline attachments are rendered in the right order when we get the message from the server.