-
-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🧑💻 Make Client.intents
writable
#2687
base: master
Are you sure you want to change the base?
feat: 🧑💻 Make Client.intents
writable
#2687
Conversation
Client.intents
writableClient.intents
writable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe intents are read-only because they shouldn't be changed after initialization. Once the client connects, intents shouldn't change
I'm going to add some kind of check to see if the connection state is connected or not and act accordingly to allow or disallow the setting. |
Yeah that's the reason |
The issue is something else entirely. This pull request adda a setter for |
Yup I missed that. Let me rewrite all this a bit and come back |
d53f249
to
c743b49
Compare
There we go |
c743b49
to
4829614
Compare
Summary
I have no idea why intents were read-only in the first place. Maybe they should stay so, or maybe smth different should be done about it.This PR allows to edit intents of a
Client
as long as the client wasn't connected yet.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.