Release v0.10.8 #176
Merged
Release v0.10.8 #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zoedberg
requested changes
Oct 9, 2023
There was a problem hiding this comment.
Build of rgb-wallet fails with the following error:
Compiling rgb-wallet v0.10.8
error[E0277]: the trait bound `InternalPk: From<bitcoin::secp256k1::XOnlyPublicKey>` is not satisfied
--> /home/zoe/.cargo/registry/src/index.crates.io-6f17d22bba15001f/rgb-wallet-0.10.8/src/psbt/dbc.rs:142:42
|
142 | internal_pk: internal_pk.into(),
| ^^^^ the trait `From<bitcoin::secp256k1::XOnlyPublicKey>` is not implemented for `InternalPk`
|
= help: the trait `From<XOnlyPk>` is implemented for `InternalPk`
= note: required for `bitcoin::secp256k1::XOnlyPublicKey` to implement `Into<InternalPk>`
For more information about this error, try `rustc --explain E0277`.
error: could not compile `rgb-wallet` (lib) due to previous error
zoedberg
previously approved these changes
Oct 9, 2023
There was a problem hiding this comment.
By patching bp-core with BP-WG/bp-core#61 this works, so ACK
|
Strage Github closed PR by itself. Anyway, will wait for @cryptoquick confirmation and than do the release |
Codecov Report
@@ Coverage Diff @@
## master #176 +/- ##
======================================
Coverage 12.8% 12.8%
======================================
Files 30 30
Lines 3079 3079
======================================
Hits 394 394
Misses 2685 2685
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zoedberg
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will wait until both @zoedberg and @cryptoquick will confirm that their systems works against this release.
There were no significant changes - just API refinement, rust lints and dependency updates - but there was a lot of new code in BP consensus which was added (and not used in RGB). Nothing in strict types shows that any RGB-related data had changed - and downstream everything compiles against this release - but just in case, want to make sure that for you guys everything also works as expected.