Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore aborted transfer tests with applied fix #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

dr-orlovsky
Copy link
Member

@dr-orlovsky dr-orlovsky commented Jan 6, 2025

Applies fix from RGB-WG/rgb-std#288 to #23

Related issue: RGB-WG/rgb-std#287

Uses improvement from RGB-WG/rgb#269

@dr-orlovsky dr-orlovsky added the bug Something isn't working label Jan 6, 2025
@dr-orlovsky dr-orlovsky requested a review from zoedberg January 6, 2025 10:52
@dr-orlovsky dr-orlovsky self-assigned this Jan 6, 2025
@dr-orlovsky
Copy link
Member Author

dr-orlovsky commented Jan 6, 2025

@zoedberg, the mining status of transactions remains tentative - of both published and unpublished, and thus they are both now excluded from the state. I do not know which method to call in order to get the second transaction mined. With that, the test should pass.

@dr-orlovsky
Copy link
Member Author

I also believe this should be rebased on #27 - with this same_transfer_twice_no_update_witnesses will not fail.

@zoedberg
Copy link
Collaborator

zoedberg commented Jan 6, 2025

I do not know which method to call in order to get the second transaction mined

check mine_tx

@dr-orlovsky dr-orlovsky marked this pull request as ready for review January 7, 2025 17:38
@dr-orlovsky
Copy link
Member Author

This test fixes one of the two problems:

  • the previously failing same_transfer_twice_no_update_witnesses now passes
  • however same_transfer_twice_update_witnesses still fails on blind transfer, since this is unrelated bug and has to be fixed separately

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants