RAC-5743: unit test doesn't exit after upgrading mocha to 4.0.1 #318
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paired with @mcgG
Unit test doesn't exit after upgrading mocha to 4.0.1 because the new version of mocha won't exit if there are running process.
There are 3 kinds of cases that make mocha hangs
Fix: set the option "reconnect" to false in stop() to avoid the issue.
Fix: call close() in stop() to close socket.
Fix: replace stub object with stub method of object in beforeEach. The stubbed methods will be restored in afterEach().
@mcgG @anhou @pengz1