Move listener instantiation out of constructor (#139) #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspected that the issue lay in the listener being created in the constructor, and playing havoc with the `this` scope so I broke it out into its own function and passed the necessary parameters in. This succeeded in resolving the issue reported in ReactTraining#139 by removing the root of the issue instead of covering it up with my previous PR.
|
sigh once again, I found a bug with this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspected that the issue lay in the listener being created in the
constructor, and playing havoc with the
thisscope so I broke it outinto its own function and passed the necessary parameters in. This
succeeded in resolving the issue reported in #139 by removing the root
of the issue instead of covering it up with my previous PR.