Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Security-Compliance Branch Build and Tagging Support #1048

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Adding Security-Compliance Branch Build and Tagging Support #1048

merged 2 commits into from
Oct 10, 2023

Conversation

casey-williams-rh
Copy link
Contributor

Overview

This PR adds the logic to the build_deploy.sh file to allow image building and tagging based on whether the branch name is security-compliance.

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

@jira-linking
Copy link

jira-linking bot commented Sep 25, 2023 •
edited
Loading

Commits missing Jira IDs:
123f01e
7d2c4d9

@ddonahue007 ddonahue007 self-requested a review October 10, 2023 14:09
ddonahue007
ddonahue007 approved these changes Oct 10, 2023
View reviewed changes
Copy link

@ddonahue007 ddonahue007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@shannon-donahue shannon-donahue merged commit 7db1d81 into RedHatInsights:master Oct 10, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddonahue007 ddonahue007 ddonahue007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@casey-williams-rh @ddonahue007 @shannon-donahue