Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reposcan): add CSAF sync task #1063

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

michalslomczynski
Copy link
Contributor

Secure Coding Practices Checklist GitHub Link

Secure Coding Checklist

  • Input Validation
  • Output Encoding
  • Authentication and Password Management
  • Session Management
  • Access Control
  • Cryptographic Practices
  • Error Handling and Logging
  • Data Protection
  • Communication Security
  • System Configuration
  • Database Security
  • File Management
  • Memory Management
  • General Coding Practices

Copy link

jira-linking bot commented Jan 11, 2024

Commits missing Jira IDs:
971fc92

@michalslomczynski michalslomczynski force-pushed the csaf-sync branch 7 times, most recently from 5c04b1b to 25bec4d Compare January 11, 2024 21:07
@codecov-commenter
Copy link

codecov-commenter commented Jan 11, 2024

Codecov Report

Attention: 17 lines in your changes are missing coverage. Please review.

Comparison is base (6961630) 61.56% compared to head (971fc92) 61.11%.

Files Patch % Lines
vmaas/reposcan/reposcan.py 34.61% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1063      +/-   ##
==========================================
- Coverage   61.56%   61.11%   -0.45%     
==========================================
  Files          66       68       +2     
  Lines        6041     6216     +175     
==========================================
+ Hits         3719     3799      +80     
- Misses       2322     2417      +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@psegedy
Copy link
Member

psegedy commented Jan 12, 2024

Tests are failing because sync now takes too long and also the local development with docker-compose will be harder because you'd need to wait at least an hour for the sync.
I'd suggest to do something similar as we are doing with OVAL and repolists. Let's add modified changes.csv (e.g. only with 2023 cves) and jsons referenced in changes.csv to https://github.com/RedHatInsights/vmaas-data. Then we can set env to point to vmaas-data repo and download files from there. The env would need to be set in reposcan.env and in app-interface vmaas ephemeral deploy target.
@mtclinton what do you think?
@michalslomczynski would you mind doing that?

@michalslomczynski
Copy link
Contributor Author

Will do, thanks for proposing resolution.

@mtclinton
Copy link
Contributor

yes, I like this solution :)

@psegedy
Copy link
Member

psegedy commented Jan 22, 2024

/retest

@jdobes jdobes merged commit 67c24d2 into RedHatInsights:master Jan 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants