add a remote room file option #299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliemar
requested review from
megatroom,
angeliski and
hashtegner
and removed request for
megatroom
Verhaeg
reviewed
Apr 7, 2020
README.md
Outdated
| @@ -109,6 +109,10 @@ The **#matrix** project has some environment variables that important to define. | |||
| } | |||
| ] | |||
|
|
|||
| Other option is to have a remote rooms config file. You can to configure a `ROOMS_SOURCE=REMOTE` and config `ROOMS_DATA` like the example: | |||
There was a problem hiding this comment.
Little typo here:
Another option is to have a remote rooms config file. You can configure
ROOMS_SOURCE=REMOTEand configROOMS_DATAlike the example:
Maybe also add a note that the file must be publicly accessible in this case.
juliemar
commented
Apr 7, 2020
angeliski
previously approved these changes
Apr 7, 2020
Co-Authored-By: Rogerio Angeliski <[email protected]>
Good Idea @angeliski I don't have an idea how to do it :) I'll merge this PR and you can open another with this check 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We have some issues talking about difficult to manage the environment variable
ROOMS_DATAError when using custom ROOMs (docker compose env)
Matrix not reading ROOMS_DATA from env file
ROOMS single line environment variable is tuff to use when you have too many rooms
This PR I put a new option to read a remote
.jsonfile.How to test?
Setup Environment variable
ROOMS_SOURCE=REMOTEand theROOMS_DATAwith a link to thejsonroom's source file.Expected behavior
#matrix needs to make an office with the virtual rooms configured in the remote
.jsonfile.