-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add room groups #335
base: develop
Are you sure you want to change the base?
Add room groups #335
Conversation
refactors RoomGroup component into separate file
Codeclimate is showing the same error as it did before. It seems to happen only when a new file is added to the project. |
|
||
Example: | ||
|
||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @phiter What do you think we change the room structure to?
{
group-id: "Group-1",
name: "My Group Name"
rooms: [
{
"id": "${UUID}",
"name": "First room",
},
{
"id": "${UUID}",
"name": "Second room",
},
{
"id": "${UUID}",
"name": "Another room"
}
]
}
We will break the current payload, but I think this is the best way to improve and simplify the way to manage rooms.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @juliemar, thanks for reviewing it.
I thought about that too, would probably be better but I wanted to make the change as small as possible, specially considering some people won't be using the grouping feature.
Changing the structure would probably need changes in many different places, specially the api which I didn't touch yet.
I suppose we could keep the grouping feature as it is now and maybe try something different in the future?
Description
This PR adds a feature that allows rooms to be grouped, providing a better way to organize the office. Currently it is just a visual change. The room groups can be closed and opened as well, and the states are persisted in the localstorage.
Resolves #208
How to test?
Add a
group
option to any room and give it a name.Expected behavior
The room should be grouped within the main interface.
Similar to this: