-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add i18next and language switcher #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gonna fix those codeclimate issues later today. |
These codeclimate issues are odd. It says invalid token Example: matrix/frontend/src/components/RoomCard.js Lines 60 to 118 in fe762bf
|
Adds i18n to login application and refactors google signin button
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds i18next and react-i18next libraries to the project to initialize the i18n feature.
It also adds a language switch component to both the office and room appbars.
Initially only basic english and portuguese translations have been created.
The language will be set automatically according to the browser setting and if the user changes the language, the choice will be stored in the localStorage.
resolves #341
How to test?
Expected behavior
The language names will change to their versions in the selected language, as well as the tooltip of the language switcher menu activator.