Handle debounce in I2CKeypad_interrupts_1 example #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, The example code in I2CKeypad_interrupts_1.ino has a potential bug. The
loop()
function doesn't handle the case wheregetKey()
returnsI2C_KEYPAD_THRESHOLD
(255). Instead, it uses the number 255 as an index into an array of 19 bytes. That's an invalid memory access. To fix it, the following should be added after the call to getKey().Perhaps it's not really a bug since it doesn't call the new
setDebounceThreshold()
method, but this pull request does that as well. It might not strictly be necessary for this example, but I think it makes it a better example.