fix(platform): Combine Sorting, Filtering, and Grouping Settings into a Single Dialog #12502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… filtering, and grouping dialogs into a single settings dialog.
dpavlenishvili
added
code refactoring
nice to have
2 tasks
❌ Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-ngx/deploys
|
|
Visit the preview URL for this PR (updated for commit 172b084): https://fundamental-ngx-gh--pr12502-12441-table-settings-jwj8zdvf.web.app (expires Thu, 26 Dec 2024 15:07:49 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
dpavlenishvili
changed the title
droshev
changed the title
...tform/table/components/table-view-settings-dialog/filtering/filters-list-step.component.html
Outdated
Show resolved
Hide resolved
libs/platform/table/components/table-view-settings-dialog/filtering/filters.component.ts
Outdated
Show resolved
Hide resolved
|
@dpavlenishvili Great work! few comments:
|
…ems, remove unused cdt declaration, removed signal effect and used just input set to listen filteringData change to triger relevant methods accordingly.
# Conflicts: # libs/platform/table/components/table-view-settings-dialog/grouping/grouping.component.html # libs/platform/table/components/table-view-settings-dialog/grouping/grouping.component.ts # libs/platform/table/components/table-view-settings-dialog/sorting/sorting.component.html # libs/platform/table/components/table-view-settings-dialog/sorting/sorting.component.ts
...m/table/components/table-view-settings-dialog/settings-dialog/settings-dialog.component.scss
Outdated
Show resolved
Hide resolved
i updated all examples |
mikerodonnell89
requested changes
Oct 14, 2024
There was a problem hiding this comment.
Looking good! Some small things:
- The "Group" option the advanced techniques table doesn't appear to do anything: https://deploy-preview-12502--fundamental-ngx.netlify.app/#/platform/table/advanced
Screen.Recording.2024-10-14.at.2.18.05.PM.mov
- Same example, trying to filter by statusColor throws a console error:
# Conflicts: # libs/i18n/src/lib/models/fd-language-key-identifier.ts # libs/i18n/src/lib/translations/translations.properties # libs/i18n/src/lib/translations/translations.ts
|
@dpavlenishvili resolve the conflicts, check unit/e2e. Apart from that nothing else is remaining. |
…dialog-revisit # Conflicts: # libs/i18n/src/lib/translations/translations.properties # libs/i18n/src/lib/translations/translations.ts
|
@dpavlenishvili check unit/e2e. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes #12441 #12447 #12181
Description
This PR refactors the TableViewSettingsDialogComponent to combine sorting, filtering, and grouping functionality into a single dialog. Previously, sorting, filtering, and grouping were handled by separate dialogs, but now they are merged for a more streamlined user experience. This also reduces code duplication and improves maintainability.
Key changes:
Screenshots
Before:
After:
Screen.Recording.2024-10-03.at.15.18.55.mov