Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): combobox communicateByObject bugs #12815

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

mikerodonnell89
Copy link
Member

fixes #12519

  • Fixes a bug where the onChange/valueChange is triggered every keystroke for communicateByObject, when the docs say it should only fire when an item from the dropdown is actually selected
  • Fixes a bug where selecting an item that has a matching display name with another item doesn't actually select either of them (vid below)

Before

Screen.Recording.2024-12-05.at.4.13.27.PM.mov

After

Screen.Recording.2024-12-05.at.4.14.33.PM.mov

@mikerodonnell89 mikerodonnell89 requested a review from a team December 5, 2024 21:15
@mikerodonnell89 mikerodonnell89 self-assigned this Dec 5, 2024
Copy link

netlify bot commented Dec 5, 2024

Deploy Preview for fundamental-ngx ready!

Name Link
🔨 Latest commit aa50ba0
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/675217d97776df0008853c9d
😎 Deploy Preview https://deploy-preview-12815--fundamental-ngx.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Dec 5, 2024

Visit the preview URL for this PR (updated for commit aa50ba0):

https://fundamental-ngx-gh--pr12815-fix-12519-wicglu6a.web.app

(expires Sun, 08 Dec 2024 21:19:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Combobox with [communicateByObject]=true triggers on input text change
1 participant