feat(deps): angular 19 support #12834
Open
+5,242
−5,457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-ngx/deploys
|
|
@dpavlenishvili update the css imports. it should be ready for review after that. |
|
@dpavlenishvili check why the build is failing. |
droshev
force-pushed
the
12741-angular-19-support
branch
8 times, most recently
from
5e71315 to
81e6334
Compare
droshev
force-pushed
the
12741-angular-19-support
branch
from
81e6334 to
7e7e014
Compare
|
Visit the preview URL for this PR (updated for commit 7e7e014): https://fundamental-ngx-gh--pr12834-12741-angular-19-sup-8foe3aia.web.app (expires Mon, 23 Dec 2024 18:16:17 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff |
droshev
force-pushed
the
12741-angular-19-support
branch
from
3b88fea to
19067ad
Compare
# Conflicts: # package.json # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue(s)
closes #12741
Description
BREAKING CHANGE: Angular 19
Please check whether the PR fulfills the following requirements
PR Quality
https://github.com/SAP/fundamental-ngx/blob/main/CONTRIBUTING.md
https://github.com/SAP/fundamental-ngx/wiki/PR-Review-Checklist
README.md