Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core,platform): clicking list item in p13 dialog should not toggle checkbox #12878

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mikerodonnell89
Copy link
Member

fixes #12672 for the main branch

  • Adds an input preventClick to the list item component which allows the user to disable default selection/deselection behavior for list items
  • Utilizes this new input on the platform table p13 dialog so that clicking a list item doesn't handle selection - user must manually click the checkbox

…. fix issue with toggling column on p13 dialog
@mikerodonnell89 mikerodonnell89 requested a review from a team December 23, 2024 16:35
@mikerodonnell89 mikerodonnell89 self-assigned this Dec 23, 2024
Copy link

netlify bot commented Dec 23, 2024

Check the deploy log for errors here: https://app.netlify.com/sites/fundamental-ngx/deploys

Name Link
🔨 Latest commit e7d0c40
🔍 Latest deploy log https://app.netlify.com/sites/fundamental-ngx/deploys/6769916f55c09a0008ae958a

Copy link

github-actions bot commented Dec 23, 2024

Visit the preview URL for this PR (updated for commit e7d0c40):

https://fundamental-ngx-gh--pr12878-fix-12672-aveo7enm.web.app

(expires Thu, 26 Dec 2024 20:52:05 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 41b993ee8e451bd7c6770b342ce142dc886eacff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[P2][Sourcing] checkbox should not be toggled when selecting entire row in p13 dialog
1 participant