OS X support #17
Open
OS X support #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
goodboy
pushed a commit
that referenced
this pull request
Jul 28, 2016
These changes are hand picked from PR #17. For #20 this fixes the bug where underlying `Agents` do not have their `logdir` attribute set properly when passed to `pysipp.scenario`. Also included is support for more command line flags including: -oocsf, -users, -deadcall_wait and -trace_error_codes. Closes #18
added 2 commits
December 4, 2017 10:56
Use `select.select` to track subproc completion since `select.epoll` isn't available on OSX. Resolves #16
|
Just waiting for some feedback from someone having successfully used this branch and then we'll merge it. OTH if we decide to lock in py3 we can use |
|
Linking #34 - but I don't think this patch will work for Windows - |
|
Probably deprecated by #87 if the lurkerz approve 🤔 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to avoid alienating our friends with a taste for shiny, juicy, paper thin apples.