-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace tess-locator with tesswcs #10
Conversation
altuson
commented
Aug 6, 2024
•
edited
Loading
edited
- Updated predict() function: uses tesswcs instead of tess-locator to determine the pixel location.
- Created from_sector() function that allows you to initialize a TessEphem object with a target and sector.
- In query to JPL Horizons, return astrometric RA, Dec instead of apparent RA, Dec.
- Updated and added examples to README file.
- Added tests to test_ephem.py for new functions.
I've run pytests, black and flake8 locally so these should pass. |
GH actions are failing because these were defined with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've updated the actions in the main brunch. Now you have to pull from upstream in your local branch (tess-wcs
) to get the updates. Then push to your branch to update the PR.
That should fix the errors on mypy
and black8
. You have to run black
again before pushing to fix one file formatting.
Also, now it will run pytest
when making a new PR.
@jorgemarpa I have merged your changes into my |
@altuson: the actions did not pass because Poetry changed how to install developer dependencies, it works as a group now. In the Now you should pull from the upstream/main branch these changes to update your branch and the PR. Sorry we are running into all these small issues. These are because we haven't updated this repo in a while, so many things have changed a bit from last time. This would be the last one 🤞🏾 |
@jorgemarpa I've merged the new changes into this branch. Fingers crossed it all runs smoothly now! |
@altuson we are very close now. The action errors are due to different python syntax between 3.9 and 3.10 for the type hints of a function that accepts two types of variables for an argument. I suggest using |
@jorgemarpa I have made your suggested update. |
LGTM! |