ADDED: ord_difference/4, ord_partition/5 #878
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These operations (split diff, diff+intersection) felt like they were missing in the ordsets library. ord_partition/5, in particular, is a generalization of a number of different ordsets predicates; if it were not for the fact that it potentially uses more memory than simpler predicates like ord_intersection/3, I'd suggest that the others get rewritten to use ord_partition/5 as a foundation. It also brings a potential VM optimization to light: being able to propagate the "don't-care"-ness of a `_` argument into the called predicate could allow a complex, multi-modal predicate like this to be used without penalty.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These operations (split diff, diff+intersection) felt like they were
missing in the ordsets library. ord_partition/5, in particular, is a
generalization of a number of different ordsets predicates; if it were
not for the fact that it potentially uses more memory than simpler
predicates like ord_intersection/3, I'd suggest that the others get
rewritten to use ord_partition/5 as a foundation.
It also brings a potential VM optimization to light: being able to
propagate the "don't-care"-ness of a
_argument into the calledpredicate could allow a complex, multi-modal predicate like this
to be used without penalty.