Skip to content

Commit

Permalink
Version 1.5.0 release PR - "Able adenine"
Browse files Browse the repository at this point in the history
It is merged despite failing CI tests, because the one failing test pertains to the code test coverage. No patches must have a lower coverage than the overall coverage of the project. But for that particular file, testing the remaining three lines of code would require mocking hardware detection failures. These tests are very hard to implement and unhelpful with regard to `umi-transfer`.
  • Loading branch information
MatthiasZepper authored Jun 28, 2024
2 parents ace1547 + babdb13 commit 677f59b
Show file tree
Hide file tree
Showing 19 changed files with 2,589 additions and 640 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/container.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,29 +27,29 @@ jobs:
echo "REPOTITLE_LOWERCASE=$(basename ${GITHUB_REPOSITORY,,})" >> ${GITHUB_ENV}
- name: Log in to Docker Hub
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
username: ${{ secrets.DOCKERHUB_USERNAME }}
password: ${{ secrets.DOCKERHUB_TOKEN }}

- name: Login to GitHub Container Registry
uses: docker/login-action@v2
uses: docker/login-action@v3
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

- name: Push dev image
uses: docker/build-push-action@v3
if: github.event_name == 'push'
uses: docker/build-push-action@v5
if: github.event_name == 'push' || github.event_name == 'workflow_dispatch'
with:
push: true
tags: |
${{ secrets.DOCKERHUB_USERNAME }}/${{ env.REPOTITLE_LOWERCASE }}:dev
ghcr.io/${{ env.REPO_LOWERCASE }}:dev
- name: Push release image
uses: docker/build-push-action@v3
uses: docker/build-push-action@v5
if: github.event_name == 'release'
with:
push: true
Expand Down
26 changes: 21 additions & 5 deletions .github/workflows/testing.yml
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ jobs:
continue-on-error: true

- name: Create an artifact from clippy results
uses: actions/upload-artifact@v3
uses: actions/upload-artifact@v4
with:
name: ClippyResults
path: rust-clippy-results.sarif
Expand All @@ -102,16 +102,32 @@ jobs:
tarpaulin:
name: Determine test coverage with Tarpaulin
runs-on: ubuntu-latest
container:
image: xd009642/tarpaulin:develop-nightly
options: --security-opt seccomp=unconfined
steps:
- name: Checkout repository
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4

- name: Setup Rust
uses: dtolnay/rust-toolchain@stable

- name: Install tarpaulin
run: cargo install cargo-tarpaulin

- name: Cache Rust toolchain
uses: Swatinem/rust-cache@23bce251a8cd2ffc3c1075eaa2367cf899916d84 # v2

- name: Generate code coverage
run: |
cargo +nightly tarpaulin --workspace --benches --follow-exec --timeout 120 --out Xml
cargo-tarpaulin --tests --bins --follow-exec --timeout 120 --out Xml
- uses: actions/upload-artifact@v4
with:
name: TarpaulinCodeCoverage.xml
path: cobertura.xml

- name: Upload coverage reports to Codecov
uses: codecov/[email protected]
with:
token: ${{ secrets.CODECOV_TOKEN }}



Loading

0 comments on commit 677f59b

Please sign in to comment.