-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Version 1.5.0 release PR - "Able adenine"
It is merged despite failing CI tests, because the one failing test pertains to the code test coverage. No patches must have a lower coverage than the overall coverage of the project. But for that particular file, testing the remaining three lines of code would require mocking hardware detection failures. These tests are very hard to implement and unhelpful with regard to `umi-transfer`.
- Loading branch information
Showing
19 changed files
with
2,589 additions
and
640 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -88,7 +88,7 @@ jobs: | |
continue-on-error: true | ||
|
||
- name: Create an artifact from clippy results | ||
uses: actions/upload-artifact@v3 | ||
uses: actions/upload-artifact@v4 | ||
with: | ||
name: ClippyResults | ||
path: rust-clippy-results.sarif | ||
|
@@ -102,16 +102,32 @@ jobs: | |
tarpaulin: | ||
name: Determine test coverage with Tarpaulin | ||
runs-on: ubuntu-latest | ||
container: | ||
image: xd009642/tarpaulin:develop-nightly | ||
options: --security-opt seccomp=unconfined | ||
steps: | ||
- name: Checkout repository | ||
uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4 | ||
|
||
- name: Setup Rust | ||
uses: dtolnay/rust-toolchain@stable | ||
|
||
- name: Install tarpaulin | ||
run: cargo install cargo-tarpaulin | ||
|
||
- name: Cache Rust toolchain | ||
uses: Swatinem/rust-cache@23bce251a8cd2ffc3c1075eaa2367cf899916d84 # v2 | ||
|
||
- name: Generate code coverage | ||
run: | | ||
cargo +nightly tarpaulin --workspace --benches --follow-exec --timeout 120 --out Xml | ||
cargo-tarpaulin --tests --bins --follow-exec --timeout 120 --out Xml | ||
- uses: actions/upload-artifact@v4 | ||
with: | ||
name: TarpaulinCodeCoverage.xml | ||
path: cobertura.xml | ||
|
||
- name: Upload coverage reports to Codecov | ||
uses: codecov/[email protected] | ||
with: | ||
token: ${{ secrets.CODECOV_TOKEN }} | ||
|
||
|
||
|
Oops, something went wrong.