Make single and multi-file AD torrents known to SymlinkDownloader #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…look for the file in this directory, in `ADTorrentClient`, use the torrent's `Filename` for the file's `Path` if there is only one file, and in `DownloadHelper`, return this if there's only one file in the torrent and it's an alldebrid torrent
|
Superseded by 8fe277f and 38a3bc1 (rogerfar#648 (comment)). Thank you so much for your help in fixing the bug! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, by setting
Pathtotorrent.Filenameiftorrent.Links.Count == 1, whenSymlinkDownloaderchecks the""potentialFilePath, it will look for/mnt-path/<torrent.Filename>(which is where it will be).Secondly, for the multi-file torrents, I've decided to just look directly at whatever directory the argument
pathspecifies.I'm a massive dotnet noob, so this may be non-idiomatic or approached wrong, but it does work for
TestMultiple.torrentandName Mismatch (Single File)(although rdt-client should probably error for this type of file since it's unreadable) .I haven't implemented the erroring part when the single file is in a subdirectory - I'm not quite sure where should error. Since we know as soon as we get the
/magnets/statusresponse, we could error inAllDebridTorrentClient.GetTorrents- but we'd have to know that this was intended for the symlink downloader. Erroring in theSymlinkDownloadermight make more sense?