Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency rubocop to v1.69.0 - abandoned #2080

Closed
wants to merge 3 commits into from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 26, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
rubocop (source, changelog) 1.68.0 -> 1.69.0 age adoption passing confidence

Release Notes

rubocop/rubocop (rubocop)

v1.69.0

Compare Source

New features
Bug fixes
  • #​13455: Fix a false positive for Layout/EmptyLineAfterGuardClause when using a guard clause outside oneliner block. ([@​koic][])
  • #​13412: Fix a false positive for Style/RedundantLineContinuation when there is a line continuation at the end of Ruby code followed by __END__ data. ([@​koic][])
  • #​13476: Allow to write generics type of RBS::Inline annotation after subclass definition in Style/CommentedKeyword. ([@​dak2][])
  • #​13441: Fix an incorrect autocorrect for Style/IfWithSemicolon when using return with value in if with a semicolon is used. ([@​koic][])
  • #​13448: Fix an incorrect autocorrect for Style/IfWithSemicolon when the then body contains an arithmetic operator method call with an argument. ([@​koic][])
  • #​13199: Make Style/RedundantCondition skip autocorrection when a branch has a comment. ([@​koic][])
  • #​13411: Fix Style/BitwisePredicate when having regular method. ([@​d4be4st][])
  • #​13432: Fix false positive for Lint/FloatComparison against nil. ([@​lovro-bikic][])
  • #​13461: Fix false positives for Lint/InterpolationCheck when using invalid syntax in interpolation. ([@​koic][])
  • #​13402: Fix a false positive for Lint/SafeNavigationConsistency when using unsafe navigation with both && and ||. ([@​koic][])
  • #​13434: Fix a false positive for Naming/MemoizedInstanceVariableName for assignment methods`. ([@​earlopain][])
  • #​13415: Fix false positives for Naming/MemoizedInstanceVariableName when using initialize_clone, initialize_copy, or initialize_dup. ([@​koic][])
  • #​13421: Fix false positives for Style/SafeNavigation when using a method chain that exceeds the MaxChainLength value and includes safe navigation operator. ([@​koic][])
  • #​13433: Fix autocorrection for Style/AccessModifierDeclarations for multiple inline symbols. ([@​dvandersluis][])
  • #​13430: Fix EmptyLinesAroundMethodBody for methods with arguments spanning multiple lines. ([@​aduth][])
  • #​13438: Fix incorrect correction in Lint/Void if an operator is called in a void context using a dot. ([@​dvandersluis][])
  • #​13419: Fix Lint/DeprecatedOpenSSLConstant false positive when the argument is a safe navigation method call. ([@​dvandersluis][])
  • #​13404: Fix Style/AccessModifierDeclarations to register (as positive or negative, depending on AllowModifiersOnSymbols value) access modifiers with multiple symbols. ([@​dvandersluis][])
  • #​13436: Fix incorrect offense and autocorrect for Lint/RedundantSplatExpansion when percent literal array is used in a safe navigation method call. ([@​lovro-bikic][])
  • #​13442: Fix an incorrect autocorrect for Style/NestedTernaryOperator when ternary operators are nested and the inner condition is parenthesized. ([@​koic][])
  • #​13444: Fix an incorrect autocorrect for Style/OneLineConditional when the else branch of a ternary operator has multiple expressions. ([@​koic][])
  • #​13483: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using escaped double quote character. ([@​koic][])
  • #​13497: Fix infinite loop error for Style/IfWithSemicolon when using nested if/;/end in if body. ([@​koic][])
  • #​13477: Update Layout/LeadingCommentSpace to accept multiline shebangs at the top of the file. ([@​dvandersluis][])
  • #​13453: Update Style/AccessModifierDeclarations to handle attr_* methods with multiple parameters. ([@​dvandersluis][])
  • #​12597: Update Style/SingleLineDoEndBlock to not register an offense if it will introduce a conflicting Layout/RedundantLineBreak offense. ([@​dvandersluis][])
Changes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for selenium-dev ready!

Name Link
🔨 Latest commit 8a84e31
🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/6755dc402c01e50008ff2c66
😎 Deploy Preview https://deploy-preview-2080--selenium-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

qodo-merge-pro bot commented Nov 26, 2024

CI Failure Feedback 🧐

(Checks updated until commit 8a84e31)

Action: tests (windows, stable)

Failed stage: Run tests [❌]

Failed test name: Internet Explorer Options ensures a clean session

Failure summary:

The action failed due to multiple test failures in the RSpec suite:

  • The test Internet Explorer Options ensures a clean session failed due to a Net::ReadTimeout error
    when calling driver.quit.
  • The test Internet Explorer Service sets log level failed because of a Errno::ECONNREFUSED error,
    indicating that a TCP connection to 127.0.0.1:5556 was refused.
  • The test Internet Explorer Service logs to file also failed due to a Errno::ECONNREFUSED error for
    the same reason as above.
  • The test Internet Explorer Service logs to console failed with a similar Errno::ECONNREFUSED error.

  • Relevant error logs:
    1:  ##[group]Operating System
    2:  Microsoft Windows Server 2022
    ...
    
    354:  timeout_minutes: 20
    355:  max_attempts: 3
    356:  command: cd examples/ruby
    357:  bundle exec rspec
    358:  
    359:  retry_wait_seconds: 10
    360:  polling_interval_seconds: 1
    361:  warning_on_retry: true
    362:  continue_on_error: false
    ...
    
    445:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:45:in `invoke'
    446:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/exe/rspec:4:in `<top (required)>'
    447:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/bin/rspec:25:in `load'
    448:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/bin/rspec:25:in `<main>'
    449:  ....
    450:  Pending: (Failures listed here are expected and do not affect your suite's status)
    451:  1) Keys copy and paste
    452:  # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    453:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    454:  expected: "SeleniumSelenium!"
    455:  got: "!"
    456:  (compared using ==)
    457:  # ./spec/actions_api/keys_spec.rb:76:in `block (2 levels) in <top (required)>'
    458:  2) Network waits for downloads
    459:  # Test guarded; Guarded by {:platform=>:windows, :reason=>"No reason given"};
    460:  Failure/Error: expect { Selenium::WebDriver::Wait.new.until { @completed } }.not_to raise_exception
    461:  expected no Exception, got #<Selenium::WebDriver::Error::TimeoutError: timed out after 5 seconds> with backtrace:
    ...
    
    555:  33) Element Locators with relative locators finds near element
    556:  # These are reference following the documentation example
    557:  # ./spec/elements/locators_spec.rb:55
    558:  34) Element Locators with relative locators chains relative locators
    559:  # These are reference following the documentation example
    560:  # ./spec/elements/locators_spec.rb:59
    561:  Failures:
    562:  1) Internet Explorer Options ensures a clean session
    563:  Failure/Error: driver.quit
    564:  Net::ReadTimeout:
    565:  Net::ReadTimeout with #<TCPSocket:(closed)>
    566:  # ./spec/browsers/internet_explorer_spec.rb:37:in `block (3 levels) in <top (required)>'
    567:  2) Internet Explorer Service sets log level
    568:  Failure/Error: config.after { @driver&.quit }
    569:  Errno::ECONNREFUSED:
    570:  Failed to open TCP connection to 127.0.0.1:5556 (No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556)
    571:  # ./spec/spec_helper.rb:28:in `block (2 levels) in <top (required)>'
    572:  # ------------------
    573:  # --- Caused by: ---
    574:  # Errno::ECONNREFUSED:
    575:  #   No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556
    576:  #   ./spec/spec_helper.rb:28:in `block (2 levels) in <top (required)>'
    577:  Finished in 11 minutes 49 seconds (files took 36.12 seconds to load)
    578:  185 examples, 2 failures, 34 pending
    579:  Failed examples:
    580:  rspec ./spec/browsers/internet_explorer_spec.rb:34 # Internet Explorer Options ensures a clean session
    581:  rspec ./spec/browsers/internet_explorer_spec.rb:98 # Internet Explorer Service sets log level
    582:  ##[warning]Attempt 1 failed. Reason: Child_process exited with error code 1
    ...
    
    594:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:72:in `block in unclosed_tokens_in_line_range'
    595:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/flat_map.rb:7:in `each'
    596:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/flat_map.rb:7:in `flat_map'
    597:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/flat_map.rb:7:in `flat_map'
    598:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:71:in `unclosed_tokens_in_line_range'
    599:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:58:in `line_range_of_expression'
    600:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:42:in `expression_lines'
    601:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:31:in `extract_expression_lines_at'
    602:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:248:in `read_failed_lines'
    603:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:171:in `failure_slash_error_lines'
    604:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:158:in `block in failure_lines'
    ...
    
    626:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:71:in `run'
    627:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:45:in `invoke'
    628:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/exe/rspec:4:in `<top (required)>'
    629:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/bin/rspec:25:in `load'
    630:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/bin/rspec:25:in `<main>'
    631:  Pending: (Failures listed here are expected and do not affect your suite's status)
    632:  1) Keys copy and paste
    633:  # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    634:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    635:  expected: "SeleniumSelenium!"
    636:  got: "!"
    637:  (compared using ==)
    638:  # ./spec/actions_api/keys_spec.rb:76:in `block (2 levels) in <top (required)>'
    639:  2) Network waits for downloads
    640:  # Test guarded; Guarded by {:platform=>:windows, :reason=>"No reason given"};
    641:  Failure/Error: expect { Selenium::WebDriver::Wait.new.until { @completed } }.not_to raise_exception
    642:  expected no Exception, got #<Selenium::WebDriver::Error::TimeoutError: timed out after 5 seconds> with backtrace:
    ...
    
    736:  33) Element Locators with relative locators finds near element
    737:  # These are reference following the documentation example
    738:  # ./spec/elements/locators_spec.rb:55
    739:  34) Element Locators with relative locators chains relative locators
    740:  # These are reference following the documentation example
    741:  # ./spec/elements/locators_spec.rb:59
    742:  Failures:
    743:  1) Internet Explorer Service logs to file
    744:  Failure/Error: config.after { @driver&.quit }
    745:  Errno::ECONNREFUSED:
    746:  Failed to open TCP connection to 127.0.0.1:5556 (No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556)
    747:  # ./spec/spec_helper.rb:28:in `block (2 levels) in <top (required)>'
    748:  # ------------------
    749:  # --- Caused by: ---
    750:  # Errno::ECONNREFUSED:
    751:  #   No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556
    752:  #   ./spec/spec_helper.rb:28:in `block (2 levels) in <top (required)>'
    753:  Finished in 7 minutes 54 seconds (files took 3.13 seconds to load)
    754:  185 examples, 1 failure, 34 pending
    755:  Failed examples:
    756:  rspec ./spec/browsers/internet_explorer_spec.rb:79 # Internet Explorer Service logs to file
    757:  ##[warning]Attempt 2 failed. Reason: Child_process exited with error code 1
    ...
    
    1122:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:72:in `block in unclosed_tokens_in_line_range'
    1123:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/flat_map.rb:7:in `each'
    1124:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/flat_map.rb:7:in `flat_map'
    1125:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/flat_map.rb:7:in `flat_map'
    1126:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:71:in `unclosed_tokens_in_line_range'
    1127:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:58:in `line_range_of_expression'
    1128:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:42:in `expression_lines'
    1129:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/snippet_extractor.rb:31:in `extract_expression_lines_at'
    1130:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:248:in `read_failed_lines'
    1131:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:171:in `failure_slash_error_lines'
    1132:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/formatters/exception_presenter.rb:158:in `block in failure_lines'
    ...
    
    1154:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:71:in `run'
    1155:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/lib/rspec/core/runner.rb:45:in `invoke'
    1156:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/lib/ruby/gems/3.3.0/gems/rspec-core-3.13.0/exe/rspec:4:in `<top (required)>'
    1157:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/bin/rspec:25:in `load'
    1158:  from C:/hostedtoolcache/windows/Ruby/3.3.6/x64/bin/rspec:25:in `<main>'
    1159:  Pending: (Failures listed here are expected and do not affect your suite's status)
    1160:  1) Keys copy and paste
    1161:  # Test guarded; Guarded by {:browser=>:chrome, :reason=>"https://bugs.chromium.org/p/chromedriver/issues/detail?id=4264"};
    1162:  Failure/Error: expect(driver.find_element(id: 'textInput').attribute('value')).to eq 'SeleniumSelenium!'
    1163:  expected: "SeleniumSelenium!"
    1164:  got: "!"
    1165:  (compared using ==)
    1166:  # ./spec/actions_api/keys_spec.rb:76:in `block (2 levels) in <top (required)>'
    1167:  2) Network waits for downloads
    1168:  # Test guarded; Guarded by {:platform=>:windows, :reason=>"No reason given"};
    1169:  Failure/Error: expect { Selenium::WebDriver::Wait.new.until { @completed } }.not_to raise_exception
    1170:  expected no Exception, got #<Selenium::WebDriver::Error::TimeoutError: timed out after 5 seconds> with backtrace:
    ...
    
    1264:  33) Element Locators with relative locators finds near element
    1265:  # These are reference following the documentation example
    1266:  # ./spec/elements/locators_spec.rb:55
    1267:  34) Element Locators with relative locators chains relative locators
    1268:  # These are reference following the documentation example
    1269:  # ./spec/elements/locators_spec.rb:59
    1270:  Failures:
    1271:  1) Internet Explorer Service logs to console
    1272:  Failure/Error: config.after { @driver&.quit }
    1273:  Errno::ECONNREFUSED:
    1274:  Failed to open TCP connection to 127.0.0.1:5556 (No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556)
    1275:  # ./spec/spec_helper.rb:28:in `block (2 levels) in <top (required)>'
    1276:  # ------------------
    1277:  # --- Caused by: ---
    1278:  # Errno::ECONNREFUSED:
    1279:  #   No connection could be made because the target machine actively refused it. - connect(2) for "127.0.0.1" port 5556
    1280:  #   ./spec/spec_helper.rb:28:in `block (2 levels) in <top (required)>'
    1281:  Finished in 7 minutes 56 seconds (files took 3.2 seconds to load)
    1282:  185 examples, 1 failure, 34 pending
    1283:  Failed examples:
    1284:  rspec ./spec/browsers/internet_explorer_spec.rb:88 # Internet Explorer Service logs to console
    1285:  ##[error]Final attempt failed. Child_process exited with error code 1
    

    ✨ CI feedback usage guide:

    The CI feedback tool (/checks) automatically triggers when a PR has a failed check.
    The tool analyzes the failed checks and provides several feedbacks:

    • Failed stage
    • Failed test name
    • Failure summary
    • Relevant error logs

    In addition to being automatically triggered, the tool can also be invoked manually by commenting on a PR:

    /checks "https://github.com/{repo_name}/actions/runs/{run_number}/job/{job_number}"
    

    where {repo_name} is the name of the repository, {run_number} is the run number of the failed check, and {job_number} is the job number of the failed check.

    Configuration options

    • enable_auto_checks_feedback - if set to true, the tool will automatically provide feedback when a check is failed. Default is true.
    • excluded_checks_list - a list of checks to exclude from the feedback, for example: ["check1", "check2"]. Default is an empty list.
    • enable_help_text - if set to true, the tool will provide a help message with the feedback. Default is true.
    • persistent_comment - if set to true, the tool will overwrite a previous checks comment with the new feedback. Default is true.
    • final_update_message - if persistent_comment is true and updating a previous checks message, the tool will also create a new message: "Persistent checks updated to latest commit". Default is true.

    See more information about the checks tool in the docs.

    Copy link

    @A1exKH A1exKH left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM.

    Copy link
    Contributor Author

    renovate bot commented Nov 29, 2024

    Edited/Blocked Notification

    Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

    You can manually request rebase by checking the rebase/retry box above.

    ⚠️ Warning: custom changes will be lost.

    Copy link
    Contributor Author

    renovate bot commented Dec 17, 2024

    Autoclosing Skipped

    This PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error.

    @renovate renovate bot changed the title chore(deps): update dependency rubocop to v1.69.0 chore(deps): update dependency rubocop to v1.69.0 - abandoned Dec 17, 2024
    @harsha509 harsha509 closed this Dec 17, 2024
    @harsha509 harsha509 deleted the renovate/rubocop-1.x-lockfile branch December 17, 2024 17:12
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    2 participants