Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add java alerts code from examples to code snippet section in seleni… #2094

Merged
merged 2 commits into from
Dec 8, 2024

Conversation

praveenmar
Copy link
Contributor

@praveenmar praveenmar commented Dec 8, 2024

Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Change to the site (I have double-checked the Netlify deployment, and my changes look good)
  • Code example added (and I also added the example to all translated languages)
  • Improved translation
  • Added new translation (and I also added a notice to each document missing translation)

Checklist

  • I have read the contributing document.
  • I have used hugo to render the site/docs locally and I am sure it works.

PR Type

documentation


Description

  • Updated Java code snippets in the alerts documentation across multiple languages (English, Japanese, Portuguese, Chinese).
  • Removed unnecessary {{< badge-examples >}} from the English documentation.
  • Extended the range of lines included in the Java code snippets to provide more comprehensive examples.

Changes walkthrough 📝

Relevant files
Documentation
alerts.en.md
Update Java code snippets in English alerts documentation

website_and_docs/content/documentation/webdriver/interactions/alerts.en.md

  • Removed {{< badge-examples >}} from Java code snippets.
  • Extended Java code snippet lines in multiple sections.
  • +4/-7     
    alerts.ja.md
    Update Java code snippets in Japanese alerts documentation

    website_and_docs/content/documentation/webdriver/interactions/alerts.ja.md

    • Extended Java code snippet lines in multiple sections.
    +3/-3     
    alerts.pt-br.md
    Update Java code snippets in Portuguese alerts documentation

    website_and_docs/content/documentation/webdriver/interactions/alerts.pt-br.md

    • Extended Java code snippet lines in multiple sections.
    +3/-3     
    alerts.zh-cn.md
    Update Java code snippets in Chinese alerts documentation

    website_and_docs/content/documentation/webdriver/interactions/alerts.zh-cn.md

    • Extended Java code snippet lines in multiple sections.
    +3/-3     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    Copy link

    netlify bot commented Dec 8, 2024

    Deploy Preview for selenium-dev ready!

    Name Link
    🔨 Latest commit 071b1b7
    🔍 Latest deploy log https://app.netlify.com/sites/selenium-dev/deploys/6755cf15e81048000814655f
    😎 Deploy Preview https://deploy-preview-2094--selenium-dev.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    @CLAassistant
    Copy link

    CLAassistant commented Dec 8, 2024

    CLA assistant check
    All committers have signed the CLA.

    Copy link
    Contributor

    qodo-merge-pro bot commented Dec 8, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Line Number Mismatch
    The line range in Portuguese translation (L51-L58) differs from other translations (L51-L57), which may indicate inconsistency in code examples

    Copy link
    Contributor

    qodo-merge-pro bot commented Dec 8, 2024

    PR Code Suggestions ✨

    No code suggestions found for the PR.

    Copy link
    Member

    @harsha509 harsha509 left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Good Catch!

    Thank you @praveenmar !

    @harsha509 harsha509 merged commit 4567a5a into SeleniumHQ:trunk Dec 8, 2024
    6 checks passed
    @harsha509
    Copy link
    Member

    Congratulations on your first contribution to Selenium Docs, @praveenmar! 🎉 🎉 🎉

    selenium-ci added a commit that referenced this pull request Dec 8, 2024
    …#2094)[deploy site]
    
    * Add  java alerts code from examples to code snippet section in selenium docs (alerts.en.md)
    
    * updated correct line number 4567a5a
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants