-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[py] add remaining code for virtual authenticator #2096
Conversation
✅ Deploy Preview for selenium-dev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @Delta456 !
Test failures are expected (underlying issue with selenium manager + edge) |
* [py] add remaining code for virtual authenticator * add 723e2c9
User description
Thanks for contributing to the Selenium site and documentation!
A PR well described will help maintainers to review and merge it quickly
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, and help reviewers by making them as simple and short as possible.
Description
Added and linked code examples to respective documentation
Motivation and Context
The example was missing but the code was already written was not linked. This PR links that.
Types of changes
Checklist
PR Type
enhancement, documentation
Description
test_create_authenticator
totest_add_authenticator
in the Python test suite to better reflect its purpose.Changes walkthrough 📝
test_virtual_authenticator.py
Update test function names and comments in Python tests
examples/python/tests/interactions/test_virtual_authenticator.py
test_create_authenticator
totest_add_authenticator
.virtual_authenticator.en.md
Update Python code block references in English documentation
website_and_docs/content/documentation/webdriver/interactions/virtual_authenticator.en.md
virtual_authenticator.ja.md
Update Python code block references in Japanese documentation
website_and_docs/content/documentation/webdriver/interactions/virtual_authenticator.ja.md
virtual_authenticator.pt-br.md
Update Python code block references in Portuguese documentation
website_and_docs/content/documentation/webdriver/interactions/virtual_authenticator.pt-br.md