Add autoExpandDescription to legacy preunifiedfixes TeamNewPipe/NewPi…

…pe#1113
ShareASmile · Jun 16, 2024 · 08ecd4b · 08ecd4b
1 parent 7bd2291
commit 08ecd4b
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 1 deletion.
diff --git a/app/src/main/java/org/schabi/newpipelegacy/fragments/detail/VideoDetailFragment.java b/app/src/main/java/org/schabi/newpipelegacy/fragments/detail/VideoDetailFragment.java
@@ -1093,6 +1093,11 @@ private void setHeightThumbnail() {
 
     private void showContent() {
         contentRootLayoutHiding.setVisibility(View.VISIBLE);
+        final boolean showDescriptionOnLoad = PreferenceManager.getDefaultSharedPreferences(activity)
+                .getBoolean(getString(R.string.always_expand_description_key), false);
+        if (showDescriptionOnLoad) {
+            toggleTitleAndDescription();
+        }
     }
 
     protected void setInitialData(final int sid, final String u, final String title) {

diff --git a/app/src/main/res/values/settings_keys.xml b/app/src/main/res/values/settings_keys.xml
@@ -1171,5 +1171,6 @@
         <item>@string/grid</item>
     </string-array>
 
+    <string name="always_expand_description_key" translatable="false">always_expand_description</string>
     <string name="recaptcha_cookies_key" translatable="false">recaptcha_cookies_key</string>
 </resources>
diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -671,7 +671,6 @@
     <string name="channel_created_by">Created by %s</string>
     <string name="video_detail_by">By %s</string>
     <string name="playlist_page_summary">Playlist page</string>
-	<string name="detail_heart_img_view_description">Hearted by creator</string>
     <string name="recent">Recent</string>
     <string name="featured">Featured</string>
     <string name="radio">Radio</string>
@@ -680,4 +679,6 @@
     <string name="private_content">This content is private, so it cannot be streamed or downloaded by NewPipe.</string>
     <string name="youtube_music_premium_content">This video is available only to YouTube Music Premium members, so it cannot be streamed or downloaded by NewPipe.</string>
     <string name="paid_content">This content is only available to users who have paid, so it cannot be streamed or downloaded by NewPipe.</string>
+    <string name="always_expand_description">Always expand description</string>
+    <string name="detail_heart_img_view_description">Hearted by creator</string>
 </resources>
diff --git a/app/src/main/res/xml/appearance_settings.xml b/app/src/main/res/xml/appearance_settings.xml
@@ -35,4 +35,9 @@
         android:title="@string/caption_setting_title"
         android:summary="@string/caption_setting_description"/>
 
+    <SwitchPreference
+        app:iconSpaceReserved="false"
+        android:defaultValue="false"
+        android:key="@string/always_expand_description_key"
+        android:title="@string/always_expand_description"/>
 </PreferenceScreen>