Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rails 6.0 incompatible: annotate_rendered_view_with_filenames #129

Closed
D-system opened this issue Mar 19, 2024 · 1 comment · Fixed by #130
Closed

Rails 6.0 incompatible: annotate_rendered_view_with_filenames #129

D-system opened this issue Mar 19, 2024 · 1 comment · Fixed by #130

Comments

@D-system
Copy link

The method annotate_rendered_view_with_filenames is Rails 6.1+ only.

BetterHtml.config.annotate_rendered_view_with_filenames = ActionView::Base.annotate_rendered_view_with_filenames

I found this issue while running the test for maintenance_tasks https://github.com/Shopify/maintenance_tasks/actions/runs/8289887525/job/22695983684?pr=991

rails aborted!
NoMethodError: undefined method `annotate_rendered_view_with_filenames' for ActionView::Base:Class
/home/runner/work/maintenance_tasks/maintenance_tasks/vendor/bundle/ruby/3.0.0/gems/better_html-2.1.0/lib/better_html/railtie.rb:11:in `block (2 levels) in <class:Railtie>'
@D-system
Copy link
Author

I'm in the side of dropping activesupport 6.0 compatibility (which already is) and update the gemspec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant