Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSV accurate count #991

Merged
merged 4 commits into from
Apr 2, 2024
Merged

CSV accurate count #991

merged 4 commits into from
Apr 2, 2024

Conversation

D-system
Copy link
Contributor

Fix #977

@D-system D-system mentioned this pull request Mar 15, 2024
Closed
@D-system
Copy link
Contributor Author

I submitted the CLA. Just need to re-run the job which I can not re-run without pushing a new commit

@D-system
Copy link
Contributor Author

The failing tests are for Rails 6.0 only at the database setup because it's calling annotate_rendered_view_with_filenames which only exists as comments in test files. I'm puzzled.

@etiennebarrie
Copy link
Member

The reason is that a new version of better_html was released. On main, you can repro with this:

$ export BUNDLE_GEMFILE=$PWD/gemfiles/rails_6_0.gemfile
$ rm -f $BUNDLE_GEMFILE.lock
$ bundle
$ bin/rails test

@D-system
Copy link
Contributor Author

Thanks @etiennebarrie
I reported the issue Shopify/better-html#129

I made the necessary change for better_html in that commit ef2bfb3

@etiennebarrie
Copy link
Member

Sorry I had already reported at Shopify/better-html#122 (comment).

@D-system D-system force-pushed the csv_accurate_count branch from ef2bfb3 to b6659e2 Compare March 21, 2024 01:05
D-system added 2 commits March 21, 2024 10:07
@D-system
CSV: use accurate row count
e5b6555 
Cells can have newlines. In that case, jobs are finished with items
shown as unprocessed in the UI.
@D-system
Add remark about CSV row count for large files
bb8393c
@D-system D-system force-pushed the csv_accurate_count branch from b6659e2 to bb8393c Compare March 21, 2024 01:07
@D-system
Copy link
Contributor Author

I removed my better_error commit and rebased the PR from main

etiennebarrie
etiennebarrie reviewed Mar 21, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
app/models/maintenance_tasks/csv_collection_builder.rb Outdated Show resolved Hide resolved
app/models/maintenance_tasks/csv_collection_builder.rb Outdated Show resolved Hide resolved
@etiennebarrie etiennebarrie merged commit 613445c into Shopify:main Apr 2, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etiennebarrie etiennebarrie etiennebarrie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CSV count wrong when new line in cell
2 participants
@D-system @etiennebarrie